Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Commerce Coupon Free Shipping is a plugin for Commerce Coupon. This plugin will create a new Commerce Coupon Type and will make all processing for egalate shipping value to 0.
Project page: https://drupal.org/sandbox/Wally007/2013162
Git repository: git clone --branch 7.x-1.x http://git.drupal.org/sandbox/Wally007/2013162.git commerce_coupon_free_shipping
Comments
Comment #1
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxWally0072013162git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
sreynen CreditAttribution: sreynen commentedComment #3
doru.furtuna CreditAttribution: doru.furtuna commentedFixed all warnings reported by PAReview project.
Comment #4
ygerasimov CreditAttribution: ygerasimov commentedCode looks good. Minor cosmetic changes have been done.
Comment #5
bogdanru CreditAttribution: bogdanru commentedHi,
You should change your branch from master to a version one. Check this link https://drupal.org/node/1127732
Cheers.
Comment #6
doru.furtuna CreditAttribution: doru.furtuna commentedHi Bogdan,
I made the changes.
Thank you for remark.
Comment #7
webevt CreditAttribution: webevt commentedHi
Please take a moment to make your project page follow tips for a great project page.
PAReview script says that there's still master branch in your repository, see http://ventral.org/pareview/httpgitdrupalorgsandboxwally0072013162git.
Manual review:
Did you think of participating in a review bonus program? This will speed up the processing of your application.
Good luck
Comment #8
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #9
doru.furtuna CreditAttribution: doru.furtuna commentedHi guys,
Sorry for late.
I fixed some issues.
Can someone review please?
Thank you.
Comment #10
kscheirer$amount = $unit_price['amount'];
and your coupon gives a discount of-1 * $amount
, doesn't that make the item free instead of the shipping cost? I could be totally wrong, I'm not a commerce expert.Those issues are fairly minor, if you can remove the master branch and update your project page you'll get RTBC from me.
----
Top Shelf Modules - Crafted, Curated, Contributed.
Comment #11
doru.furtuna CreditAttribution: doru.furtuna commentedHi kscheirer,
I fixed the issues reported by you.
Related to amount, I get the amount of "shipping" price component for line item.
Thank you.
Comment #12
kscheirerThanks for those updates! If you can add more detail to your project page, you'll get an RTBC from me.
----
Top Shelf Modules - Crafted, Curated, Contributed.
Comment #13
jcisio CreditAttribution: jcisio commentedYou get directly a RTBC from me ;) I think it is enough: a simple link to the Commerce Coupon project. Another plugin, fixed amount coupon (https://drupal.org/project/commerce_coupon_fixed_amount), is not better than that.
Comment #14
kscheirerI'd love to promote this, but the project page is still blank :(
Comment #15
kscheirerComment #16
doru.furtuna CreditAttribution: doru.furtuna commentedHi kscheirer,
I have updated the description, but if you have some recommendations, you are wellcome. Because this is my first project, I don't have so many experience in writing the project pages :).
Thank you.
Comment #17
amreana CreditAttribution: amreana commentedFor some reason when i try to clone the repo i get asked for root's password for git:
root@git.drupal.org's password:
Comment #18
doru.furtuna CreditAttribution: doru.furtuna commentedtry:
git clone --branch 7.x-1.x Wally007@git.drupal.org:sandbox/Wally007/2013162.git commerce_coupon_free_shipping
Comment #19
maryedith CreditAttribution: maryedith commentedYes, it still asks for a password. I tried replacing 'Wally' with my git name, and putting in my password when asked, but still cannot download this project.
Suggestions? thanks, Mary Edith
Comment #20
inders CreditAttribution: inders commented@maryedith,
Usage:-
More Git Instructions for this project: https://drupal.org/project/2013162/git-instructions
Comment #21
heddnComment #22
heddnNothing blocking RTBC.
Info file:
Quotes aren't needed around a description: https://drupal.org/node/542202#description
Install file:
If you list commerce_coupon as a dependency, this can not be possible.
Go and add more details to your project page. This is the moment for the project to shine. Some additional tips to be found a https://drupal.org/node/2190239
Comment #23
jcisio CreditAttribution: jcisio commented#22 it could. When that function is executed (in hook_uninstall), it is possible that both modules are disabled.
Comment #24
heddnI'd still like to see more complete project documentation. Refer to guidelines for in-project & README documentation & tips for a great project page. One great tip I learned about only recently is to format your README as a markdown file and use that also for your hook help. The first link discusses that at more length.
However, nothing is blocking git access...
Thanks for your contribution, doru.furtuna!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.