Helper issue for #1953408 (Remove ArrayAccess BC layer)

Hmm contained some merge conflicts

Something went wrong with merging. Please fix the issues in the sandbox if you want to. I need my sleep ;)

Lets see

Not the expected results...

And another one

damnit, goto patch creeped in

Lets try something

This one should help alot as it fixes the field UI :p

#62: 2013679-62.patch queued for re-testing.

More fixes!

Deletion of fields was broken in the ui. Fixed.

Entity reference related fixes

#78: 2013679-78.patch queued for re-testing.

#100: 2013679-100.patch queued for re-testing.

Could be green :)

btw unrelated changes sneaked in...

core/modules/field_ui/field_ui.admin.inc and some other file

+++ b/core/lib/Drupal/Core/Entity/EntityFormController.phpundefined
@@ -459,15 +462,14 @@ protected function submitEntityLanguage(array $form, array &$form_state) {
-        $field_name = $instance['field_name'];
+        $field_name = $instance->getFieldName();

+++ b/core/lib/Drupal/Core/Entity/Query/Sql/Tables.phpundefined
@@ -138,14 +139,14 @@ function addField($field, $type, $langcode) {
-            $propertyDefinitions = $entity->{$field['field_name']}->getPropertyDefinitions();
+            $propertyDefinitions = $entity->{$field->id()}->getPropertyDefinitions();

+++ b/core/modules/block/custom_block/lib/Drupal/custom_block/Tests/CustomBlockFieldTest.phpundefined
@@ -80,12 +80,12 @@ public function testBlockFields() {
-      ->setComponent($this->field['field_name'], array(
+      ->setComponent($this->field->id(), array(

I think field_name should always be changed to getFieldName(), id() will change in the entity storage issue.

Fatal error: Cannot use object of type Drupal\field\Entity\Field as array in /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/Entity/Query/Sql/Tables.php on line 118

Fatal error: Cannot use object of type Drupal\field\Entity\Field as array in /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/entity_reference/lib/Drupal/entity_reference/Plugin/field/field_type/ConfigurableEntityReferenceItem.php on line 71

Fatal error: Cannot use object of type Drupal\field\Entity\FieldInstance as array in /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/node/lib/Drupal/node/Tests/NodeTokenReplaceTest.php on line 57

Fix these and create a new patch. Will fix most of the issues I think.

This is a terrible job :(

ARGH!

Contains more fixes

< 200 fails hopefully

go!

< 100 ? Go!

While grepping for some stuff I came around field_test.storage.inc I think it needs some work...

Last one for today

@aspilicious: field_test.storage.inc is dead code, can be removed completely. The API that it provides a test implementation for no longer exists. Not here, of course :)

I hope this one will apply, used methods in stead of direct property access

Second try

mèèh

Another try, tested this one. Site loads again...

SIGH!

We can't do empty($instance->getFieldSetting('translation_sync'))
So this needs more work :(

tomorow...

Regarding the field cache fails:
@plach's #1983554-28: Remove BC-mode from EntityNG might be related ?

Ok not sure if this is going to work...

.

Tested this one a bit better

Less fails.

I broke image handling somewhere but I can't find it.
FieldInfoTest fail is stupid field'settings'] returns something different than getFieldSettings()

Should be green now! all pushed

Test FieldAttachOtherTest probably needs follow-up for core, because actually broken now (string offset used as cardinality so no items are generated

ImageFormatterBase fix seems breaks a scope a bit but it's needed to fix test

merged head

also reverted a part and files patch to main issue #1953408-30: Remove ArrayAccess BC layer from field config entities

merge

Fix install via DatabaseStorageController.php and
clean-up TranslatableForm.php - use direct property for equality (related fix #1946462: Convert content_translation_translatable_form() to the new form interface