[D7] Promote Disable

• Fix the issues on http://ventral.org/pareview/httpgitdrupalorgsandboxjamiehollern2014429git
• Complete .info file missing core = "7.x"
• Required .install file for unset the variables like 'promote_disable_node_types'.

Link to the project page and git clone command are missing in the issue summary, please add them.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732

Hi, I just reviewed your project. These are my suggestions:

In promote_disable_form instead of building your node types array twice via _promote_disable_node_types(), you might want to store it into a variable.

  $node_types = _promote_disable_node_types();

  $form['promote_disable_node_types'] = array(
    '#type' => 'select',
    '#multiple' => TRUE,
    '#size' => count($node_types),
    '#title' => t('Node types'),
    '#default_value' => variable_get('promote_disable_node_types'),
    '#options' => $node_types,
    '#description' => t('Select the node types on which you would like to disable the "Promoted to front page" option.'),
  );

Line 71, variable_get should always get a default value as second param.
Also check for other occurences of variable_get.

Line 77, you are adding your custom form_submit function twice.

      array_unshift($form['#submit'], '_promote_disable_form_submit');
      $form['#submit'][] = '_promote_disable_form_submit';

I guess, you should change permission to "administer content types" as your settings do affect all content types available.

Just a suggestion:
User interface seems irritating to me. I can disable the promote option in the admin settings form, but on the node form it's still present. It is just disabled. Also on the node type form I can still select a default value, which would be obsolete if i checked disable promote. I would just hide this option in both forms, at it isn't needed.

Hello,

Just did a high-level review of your module's code. I have a few basic suggestions:

• Consider replacing usage of "node types" with "content types" throughout user interfaces. "Node types" might be confusing to some users since core Drupal uses "Content Types" to describe node types.
• You might also consider reorganizing your options management UI. Here I've moved what was previously the "description" of the single form element out into its own markup element. Since this description explains how to use this interface it makes sense for it to come first, followed by the actual select list.
  

  /**
   * Page callback: Promote Disable settings.
   *
   * @see promote_disable_menu()
   */
  function promote_disable_form($form, &$form_state) {
    $node_types = _promote_disable_node_types();
  
    $form = array();
    $form['promote_disable_explanation'] = array(
      '#markup' => t('Select the content types on which you would like to disable the "Promoted to front page" option.'),
    );
  
    $form['promote_disable_node_types'] = array(
      '#type' => 'select',
      '#multiple' => TRUE,
      '#size' => count($node_types),
      '#title' => t('Content types'),
      '#default_value' => variable_get('promote_disable_node_types', array()),
      '#options' => $node_types,
    );
  
    return system_settings_form($form);
  }
  

Those are my only suggestions. I ran the module through Coder and saw no code issues whatsoever. Nice work on this module, I'll definitely be reaching for this the next time I need to hide this option.

@jamiehollern, i have tested the functionality of this module. it seems working fine. @chrisfree has raised the valid points which needs to be corrected.

Nice work on this module.

Looks good to me after a visual code review.

This was RTBC already, so ...

Thanks for your contribution, jamiehollern!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.