Drupal CSS preprocessing breaks protocol-relative paths

Adding a tag.

#352951: Make JS & CSS Preprocessing Pluggable broke this. Here's a reroll.

#5: css_dont_import_protocol_relative-2014851-5.patch queued for re-testing.

looks ok to me.

I've apply the patch and reverted the change to core/lib/Drupal/Core/Asset/CssOptimizer.php and the tests fail. With they pass. Nice fix. In future it's nice to post a will fail patch that only contains the changes to the tests - so that we can confirm that we've fixed the issue and won't break it again.

Committed 4431c7e and pushed to 8.x. Thanks!

Alex: sorry, will do!

Here's a backport to D7. I don't believe this has a test in D7; can someone verify this?

There are no tests in @bradjones1's patch. Are they needed for this backport? If so we can at least tag it as "Needs tests".

What testing is required to get this into D7? The preg_replace_callback expression is the same as what got into D8, so that should be fine.

Since I can't assign this to David_Rothstein I'm going to go ahead and set the status to RTBC so he'll see it.

The change in #12 to the regex string is the same as what went into D8, but as far as I can tell the D8 tests which were modified don't exist in D7. They're CSS optimization tests. I'm not sure if they're part of some other issue waiting to be backported. I couldn't find them if they are. Do we need to find some way to backport everything in the D8 patch? If not, then #12 is RTBC.

Sorry, but this is a really major bug; one that cannot be fixed in contrib (AdvAgg still ultimately goes through core's aggregation if bundling/grouping is relatively simple enough). It's very common practice to add an @import statement for your theme's font, say from Google, at the top. I'm surprised I haven't noticed this before :-/ Regardless, here's the backported tests.

Works as expected!

Thanks.

Patch from #17 (drupal_css-2014851-17.patch) works correctly against latest drupal 7.36.

Committed to 7.x - thanks!

Fixed on commit (this list is in theory supposed to be kept up to date, as was done in the committed Drupal 8 patch):

diff --git a/modules/simpletest/tests/common.test b/modules/simpletest/tests/common.test
index 0f0347f..fcc9791 100644
--- a/modules/simpletest/tests/common.test
+++ b/modules/simpletest/tests/common.test
@@ -942,6 +942,7 @@ class CascadingStylesheetsUnitTest extends DrupalUnitTestCase {
    * - Proper URLs in imported files. (https://drupal.org/node/265719)
    * - Retain pseudo-selectors. (https://drupal.org/node/460448)
    * - Don't adjust data URIs. (https://drupal.org/node/2142441)
+   * - Files imported from external URLs. (https://drupal.org/node/2014851)
    */
   function testLoadCssBasic() {
     // Array of files to test living in 'simpletest/files/css_test_files/'.

We also should keep the files in css_test_files/css_subfolder in sync with the main ones, but I'll file a separate followup for that (affects Drupal 8 too).

And back to Drupal 6 for this issue (due to the backport tag), in case someone wants to work on it there.

@markcarver
Heads up that AdvAgg ended up copying and patching most of core's logic. As a result I keep an eye on issues like this one so that the 2 are in sync for the most part :)
#2035817: Back port some code fixes for CSS optimizations

Isn't there another solution? because patching the core every time there is an update is...
Update: never mind didn't notice this was fixed in 7.37