Hi,
i noticed that in "Recent Site Activity" some of the user-pictures are bad quality(unclear) and some of them good.
I thought its a token error(35x35 is used instead of 50x50 or thumbnail) but its a "picture-transform/compress" error.
The Pictures is ...styles/50x50/private/pictures and ...styles/35x35/private/pictures are too small.
I copied the pics from styles/thumbnail/private/pictures to styles/50x50/private/pictures(and 35) and everything is fine. But it is just a temporary solution.
My picture is 100x100 and will be showed properly in 35x35 size too so it doesnt make sense to convert the pics into too small size cause than they will be unclear.
I think im not the only one with this. I hope u can solve it. Thanks
Comment | File | Size | Author |
---|---|---|---|
#6 | before_patch.png | 138 KB | Devin Carlson |
#6 | after_patch.png | 134.38 KB | Devin Carlson |
#3 | use-standard-user-picture-image-size-2016811-3.patch | 2.06 KB | Devin Carlson |
#2 | screen.png | 41.97 KB | Laz5530 |
Comments
Comment #1
ezra-g CreditAttribution: ezra-g commentedCan you post a screenshot?
Also, have you flushed the presets for all image styles?
Where do you see the ""picture-transform/compress" error?
Comment #2
Laz5530 CreditAttribution: Laz5530 commentedHere is a screenshot:
As you can see the pictures by "commented" and "created" are not so clear as by "following".
And i think with this quality you can not recognize the person.
I looked it in the code, and the difference is that "following" uses images from the "50x50" directory.
I dont know how to "flush" the images. I changed nothing on Image-Styles.
Comment #3
Devin Carlson CreditAttribution: Devin Carlson commentedIt looks like the Q&A message types didn't get the correct user picture size during export.
Comment #4
Devin Carlson CreditAttribution: Devin Carlson commentedMarked #2018477: Partial node form displays different avatar image style than view as a duplicate.
Comment #5
ezra-g CreditAttribution: ezra-g commentedI haven't done functional testing but this patch looks good from a code review perspective.
Comment #6
Devin Carlson CreditAttribution: Devin Carlson commentedTested #3 with a fresh install of Commons and against an existing installation to check the upgrade path.
Comment #7
Devin Carlson CreditAttribution: Devin Carlson commentedCommitted #3 to Commons Q&A 7.x-3.x.
http://drupalcode.org/project/commons_q_a.git/commit/818b9b6
Comment #8
ezra-g CreditAttribution: ezra-g commentedTagging for 3.3 so we can track this when we look back at our release push :).
Comment #9
Laz5530 CreditAttribution: Laz5530 commentedThanks for the responses.
What you do with the patch is good, because ever image in the Activity Stream shouold have the same size(35x35).
But that was not my problem. I found the reason why were the images unclear, and its the "/config/media/image-styles". The style "35x35" make a scale to 35x35 but than will be a photo "full with big pixel".
I changed the scale under "/config/media/image-styles/35x35" to 60x70 so the images wont be compressed/scaled so much -> the quality will be better (they will be still shown in Activity Steam the same size(35x35))
If you could check if it has no "side-effects" and could be part of the theme.