Admin navigation list style update

#1: new-admin-list-style.patch queued for re-testing.

Lookin' good.
* The .png is misnamed in the rtl file ("list-icon-rtl.png" rather than "nav-list-icon-rtl.png")
* git apply reports trailing whitespace on the pngs.

#5 patch changed the wrong unrelated img ruleset. Here is that correction. Patch has the same git warning, but applies and stages fine. Implementation looks fine.
-------

2016875-nav-list-6.patch:26: trailing whitespace.
?PNG
2016875-nav-list-6.patch:35: trailing whitespace.
?PNG
warning: 2 lines add whitespace errors.

Can we fix these whitespace errors?

The only thing I am concerned about is the fact that it vertically centers to the title. That looks a bit strange, but it looks totally fine without descriptions. Given that many content facing occasions there won't be descriptions. I am fine with leaving that, also with typographic changes it will look better.

@Bojhan, not sure what you mean about "vertically centers to the title". With desciptions, I would think this is desired, same as previously.

The images were not transparent, they were on white. Since they are on a non white background on the config page, I've re-done the images from seventy-eight's PSD (plus optimized). I was hoping the whitespace warnings would go away, but they are the same. Note they are warnings not errors.

Only change in this patch is transparent images.

Middle alignment of icon and title, with or without a description is the way to go. I don't think a variant class is needed.

Adjustment for previously untested RTL

@echoz Nice work!

Re-roll since #2015789: Remove language_css_alter() (RTL stylesheets) in favor of HTML 'dir' attribute got committed.

Updated according to #2015789: Remove language_css_alter() (RTL stylesheets) in favor of HTML 'dir' attribute.

The patch :(

You are right @Lewis, I have included some crap from other patch, sorry :(

This is the right patch ;)

Hold on. First of all, the patches in #15 or #17 (which are identical, btw) leave out the new icons. They are changing the rtl attribute selector in seven's style.css to have quotes. But #2030925: quote rtl attribute selector has not landed yet. Whichever patch gets committed first (2030925 or this one), the other will need to be re-rolled. The patch that will work right now is #13, which I am resubmitting here. If #2030925: quote rtl attribute selector gets committed before it, I will re-roll this with changing I think only one needed "rtl".

I agree with @echoz. Sorry for the noise :(

Patch applies well and seems to work well.

This issue was RTBC and passing tests on July 1, the beginning of API freeze.

re-roll since #2030925: quote rtl attribute selector landed

#21: 2016875-nav-list-21.patch queued for re-testing.

rtl is different than in #11.
is that because the fix for rtl will be in another issue?

admin/config

no patch

no patch - rtl

patch

patch - rtl

admin/reports

no patch

patch

tagging for d8mi frontend people.

It was a specificity issue that my browser cache fooled me into thinking I had fixed.

The column css was screwed up (previous to this issue) and issue only showed up on RTL. Fixed.

patched LTR

patched RTL

#28: 2016875-nav-list-28.patch queued for re-testing.

Removed indentatation on "Hide description" display, as per #2037525: 'Hide description' layout bug

…and a screenshot

#31: 2016875-nav-list-31.patch queued for re-testing.

This still applies and should be easy to review (admin/config and admin/reports), can we move this along?

I swear I think someone at NYCCamp made all the before and after screenshots and double checked this...

This smells like RTBC

I remember somewhere it was said we should leverage the icons from ry5n's Libricons #2032773: Use Libricons (icon font) in Seven, consider using it more broadly in core for the icons used here. In #1963886: Use HiDPI icons in the toolbar only the icons used in toolbar were added in misc/icons, which included chevron-disc up + down but not left + right, which are part of Libricons and the ones used here in the admin nav lists.

This new patch is the same as #31 patch, which still applys and was ready for rtbc, plus uses the svg (w/ Modernizer png fallback) from misc/icons.

It adds these icons, in the right color, at misc/icons:

chevron-disc-left.png
chevron-disc-left.svg
chevron-disc-right.png
chevron-disc-right.svg

It does not add the pngs (created from seventy-eight's PSDs) that had been used up to the #31 patch. If we decide not to use the svg / png from misc/icons, we can use the #31 patch.

Using svg icons from misc/icons

tagging

Patch applies well (except for the errors regarding existing icon files) and looks really good.

Maybe it's a RTBC?

The git warnings (not errors) have always been there for the pngs.

I wanted to hear if nav-list is a candidate for switching to use svg icons, which I assume is true and what this last patch #38 does. Here's a screenshot showing that ie8 gets the Modernizer png fallback.

RTL should be tested since this change (admin/config and admin/reports).

It looks ok for me. Tested for RTL and it seems to fix a bug in admin/config page. Take a look at the screenshots:

admin/config BEFORE:

admin/config AFTER:

admin/reports BEFORE:

admin/reports AFTER:

Well done echoz!!

Maybe RTBC?

Thanks for the RTL testing!
Correct, I discovered and fixed that column bug in #28 that existed previous to this issue but only showed up on RTL.

Just tested it again with LTR and RTL.
Still works - RTCB
No reroll needed.

Yes, this is ready to get in!

That looks much better!

Committed and pushed to 8.x. Thanks!