A duplicate of the issue at: https://drupal.org/node/1984424.

This patch is for the 7.x-2.0-unstable version.

CommentFileSizeAuthor
#5 media-disable-filter-caching-2017761-5.patch641 bytesRob C
#2 2017761-disable-filter-caching-2.patch417 bytesthamba
#1 1984424-disable-filter-caching-2.patch417 bytesthamba
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

thamba’s picture

thamba CreditAttribution: thamba commented
Status: Patch (to be ported) » Needs review
FileSize
1984424-disable-filter-caching-2.patch417 bytes

Patch for the 7.x-2.0-unstable version.

thamba’s picture

thamba CreditAttribution: thamba commented
FileSize
2017761-disable-filter-caching-2.patch417 bytes

Renaming the patch file to match the issue.

thamba’s picture

thamba CreditAttribution: thamba commented

A quick note to anyone trying this patch out:

You need to turn off the "Convert media tags to markup" filter in each of your textformats under admin/config/content/formats. Then turn it on again and save.

I did not get the patch working for a long time with or without cache enabled until I did the following above. This could save time for anyone out there trying to solve this issue.

Rob C’s picture

Rob C CreditAttribution: Rob C commented
Version: 7.x-2.0-unstable7 » 7.x-2.x-dev
Category: Task » Bug report
Priority: Normal » Major
Issue summary: View changes

Updating issue status. (this is still an issue, install 2.x, add media to some wysiwyg-enabled body field, visit as anonymous, presto, issue).

Rob C’s picture

Rob C CreditAttribution: Rob C commented
FileSize
media-disable-filter-caching-2017761-5.patch641 bytes

Rerolling patch for media 2.x changes.

justindodge’s picture

justindodge CreditAttribution: justindodge commented

Just re-saving the text format pages (in my case admin/config/content/formats/filtered_html and admin/config/content/formats/full_html) was sufficient to get the changes in this patch to take effect - it's not necessary to disable/re-enable any of the filters as suggested in #3.

It would probably be nice if this patch included an update hook which calls filter_formats_reset() which resets the text format caches on your behalf so that this step isn't needed.

The patch did resolve my particular issue, which was anonymous users seeing the contextual links for the file entity appear in plain text above media embedded in WYSIWYG.

Edit - Apparently filter_formats_reset() doesn't do the trick. It sure seemed like it would.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented

I'm leaning more and more towards implementing this. But maybe for only new users. It would be nice if this could be configurable.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
Issue tags: +7.x-2.0 release blocker
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Needs review » Closed (outdated)
Issue tags: -7.x-2.0 release blocker

the related duplicate issue was closed fixed , as for making it optional, leaning on 'outdated' its not going to make it for 2.0, if you want this put a patch and it'll be considered for a post 2.0 release.

removing tag '7.x-2.0 release blocker'