Can cause infinite recursion loop

Here is the patch.

Oops, here is the patch without the debug statement.

Finally, here is another one without the whitespace issue that should apply more cleanly with other patches.

Found that a recursion loop could also be caused in the og_subgroups_get_parents routine, even with the existing check of _og_subgroups_parent_search. This is because the $parents array actually gets modified later in the routine. Leave it to the customer to find just the right combination of parent data to cause these recursion problems.

In any case, here is another patch to prevent infinite recursion. Combines the previous patch with the new routine and adds a constant for the recursion depth.

Sigh. Bad copy/paste in watchdog message fixed.

Wow, I'm horrible this morning. Let's try this again without rolling in a bunch of other patches. The patch in #5 also included #1985514: Undefined index: und in _og_subgroups_get_unique_parents() , #1993944: Provide a field settings for og_subgroups_get_associated_entities so it doesn't need to fetch and load all content, #1995018: Show child groups when creating content when og_group_ref/og entityref field is using og group selector.

Here is another version that is just for this issue.

The latest code has og_subgroups_children_load_multiple() so this patch no longer applies. It also has code for detecting recursion now.