Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
13 Jun 2013 at 05:15 UTC
Updated:
29 Aug 2013 at 22:24 UTC
This project handles and easy way to configure and display a comment using the jquery library Jnotify.
Project: Jnotify
Git repository: http://drupalcode.org/sandbox/tatewaky/2018229.git
It is for Drupal 7
Comments
Comment #1
TimTheEnchanter commentedHere is an autmated review, there are some issues here that need to be resolved first.
http://ventral.org/pareview/httpgitdrupalorgsandboxtatewaky2018229git
Drupal has strict standards for things like whitespace, indentation, line length, etc. Take a look at the standards doc to get a better idea what is needed to get approved. https://drupal.org/coding-standards
Your project is still running on a master version, you will need to change that to a major version, please take a look here https://drupal.org/empty-git-master
Comment #2
TimTheEnchanter commentedThe best way to include a library in Drupal is to use the libraries api module. https://drupal.org/project/libraries Here is the reasoning behind that methodology
Your project page contains no real information about the module, and the module does not contain a readme file. Take a look at the project application checklist https://drupal.org/node/1587704 Under documentation:
Also adding hook_help in the module is an easy way to help out beginners and non-coders.
Comment #3
PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application.
I'm a robot and this is an automated message from Project Applications Scraper.