[D7] OSS SDK

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxcsunny2015135git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello.

Please, check Coder's report:

osssdk.module

• Line 33: Function comment short description must end with a full stop
• Line 33: Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().", or "* Implements hook_foo_BAR_ID_bar() for xyz_bar.tpl.php.".
• Line 56: Function comment short description must end with a full stop
• Line 56: Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().", or "* Implements hook_foo_BAR_ID_bar() for xyz_bar.tpl.php.".
• Line 58: osssdk_requirements() is an installation hook and must be declared in an install file
• Line 96: Inline comments must end in full-stops, exclamation marks, or question marks
• Line 102: Files must end in a single new line character

Create osssdk.install

hook_install

variable_set('oss_key_id','');
.. oss_key_secret

hook_uninstall

variable_del as above.

Thanks

Hello.

PAReview found many of errors, please correct them - http://ventral.org/pareview/httpgitdrupalorgsandboxcsunny2015135git-7x-1x

Also, you will need to remove the master branch.

http://ventral.org/pareview/httpgitdrupalorgsandboxcsunny2015135git is currently passing.

https://drupal.org/sandbox/csunny/2015135

• Does not link to OSS SDK for PHP, only the actual downloadable. I'm not downloading a file without getting a complete description of what's in it and seeing a project overview.
• What can a Drupal developer do with the OSS SDK for PHP? Why use this module?
• I searched the codebase for osssdk_key_id - and it's not used anywhere other than the install script and the form to enter it.

What functionality does this module actually provide? I don't see that it does anything other than describe itself to libraries and links back to Aliyun OSS.

Code too short

This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

Please let us know if you'd like to see this project promoted without granting you git vetted user status. Or set back to "needs review" if you add more code. The AWK SDK module for example provides tests and a UI submodule.

----
Top Shelf Modules - Crafted, Curated, Contributed.

In osssdk_install() you don't need to set default values for your variables. You can still provide those defaults when you read them with variable_get('varname', 'defaultvalue').

No blocking issues found - the test could be improved though. Currently I think it's just a repeat of hook_requirements?

----
Top Shelf Modules - Crafted, Curated, Contributed.

It's been a month without any problems reported, so I'm promoting this myself as per https://drupal.org/node/1125818.

Thanks for your contribution, csunny!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.