[D7] AjaxQueryBlocks

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxjohnny5th1782826git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello.

Please, use major version named branch instead of master one.

https://drupal.org/empty-git-master

Hello,

In ajaxqueryblocks.module replace:

  $get_copy = $_GET;
  $params_to_exclude = array('q', 'blocks', 'path');
  foreach ($params_to_exclude as $param) {
    unset($get_copy[$param]);
  }

With drupal_get_query_parameters which does the same function.

Thanks.

Manual Review:

• Your README.txt file has the same thing in it twice. That should be cleaned up.
• Is "cache" really the right package to put this functionality in? It doesn't seem to match the module's functionality.
• In the database, why create a new block id rather than simply using a foreign key to block.bid?
• The description for the "Load block via AJAX" form field should read "if this block needs to be loaded after initial page load" or something to that effect - while media queries are this module's specialty, this option does not require you to use one, as is suggested.
• It seems bad practice to have functions with secondary effects such as your ajaxqueryblocks_is_ajax() function also populating $settings. It would be better to return settings from an ajaxqueryblocks_get_settings() function, then simply check them afterwards.
• You have a similar faux pas in the ajaxqueryblocks_page_ajax_list() function, which serves two different purposes, one of which returns a settings array and the other which does not.

The module seems to work as expected, and I don't believe that any of the above issues are showstoppers, so I'm changing status to reviewed.

I'll look at this now in the Project applications sprint

Why is this module a fork? What are the differences? Why couldn't you contribute back to the project?

This sounds like a feature that should live in the existing Ajax Blocks project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the Ajax Blocks issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.