As #2021639: Chosen directory renamed to public from chosen, js cannot be added illustrates, using the head of chosen can break a site even when using the current tagged release of chosen module, so at least for tagged versions it'd be useful to use tagged version of chosen library,

CommentFileSizeAuthor
#4 specified_library_version-2021641-4.patch338 bytestimmarwick
#3 2021641-3-7x-1x-specified-library-version.patch442 bytessmithmilner
#2 2021641-2-7x-1x-specified-library-version.patch441 bytessmithmilner
chosen-use-tag-version.patch304 byteshefox

Comments

girishmuraly’s picture

girishmuraly commented

I agree - we should use tagged version. The patch works for me.

Marked #2022867: VERSION file has been removed from the harvesthq/chosen repo! as a duplicate.

smithmilner’s picture

smithmilner commented
StatusFileSize
new 2021641-2-7x-1x-specified-library-version.patch441 bytes

Here is a specified version for the 1.x branch

smithmilner’s picture

smithmilner commented
StatusFileSize
new 2021641-3-7x-1x-specified-library-version.patch442 bytes

Oops, due to the way git sorts tags I didn't see the newest one. This patch specifies the v0.9.15 tag for the 1.x branch.

timmarwick’s picture

timmarwick commented
StatusFileSize
new specified_library_version-2021641-4.patch338 bytes

Patch does not apply. Here is one that does.

girishmuraly’s picture

girishmuraly commented

@Timothy can you confirm you are trying on 1.x branch and the patch from #3?

So as to not confuse readers, the patch in #0 applies cleanly (at least for me) on the 2.x branch, for which this issue is on.

Can someone kindly confirm the patch for 2.x version, then mark this issue for 1.x and associate patch for that?

favrik’s picture

favrik commented

Patch #0 works for me too on version 2.x.

girishmuraly’s picture

girishmuraly commented
Status: Active » Reviewed & tested by the community

Marking RTBC, though not sure if this would get committed due to #2021639: Chosen directory renamed to public from chosen, js cannot be added

hydra’s picture

hydra commented
Status: Reviewed & tested by the community » Closed (fixed)

Well, thanks for working on this. I committed a version of #2021639: Chosen directory renamed to public from chosen, js cannot be added with the new 1.0 release of chosen, this should be working now. The trick is to use the release version, not the development version :)

hefox’s picture

hefox commented
Status: Closed (fixed) » Fixed

Fixed will be marked as closed (fixed) in 2 weeks by a bot; allows subscribers to notice it being fixed

hydra’s picture

hydra commented

Oh yeah, sry and thanks hefox! Bad habit of mine :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.