[D7] Nested checkboxes

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

There is still a master branch, make sure to set the correct default branch.

Here's my review:

1. jQuery selector doesn't apply to the checkboxes. Perhaps on line 169 of nested_checkboxes.module change 'nested-checkboxes' to 'nested_checkboxes'.
2. Value of checked boxes upon submit should be 1, not the title (to be the same as the checkbox).
3. Theme them similarly to checkboxes:
   • Put checkbox before label.
   • Add "option" class to label.
4. Some code lines are really long e.g. nested_checkboxes.module @130. For this case, you could separate the value for %name into a variable.
5. Need more inline documentation to see what's going on: e.g. theme_nested_checkboxes() in nested_checkboxes.module.

Change status to "needs work"

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

Updated usage info.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxgease2021485git

I'm a robot and this is an automated message from Project Applications Scraper.

Not easy-to-read declarations with conditions, for example, line 119 @ nested_checkbox.module

don't be fanatic in cutting lines to 80 chars: lines 142, 154, 215, 220, etc

Use Drupal.behaviors instead $(document).ready

PA Review Error:

<FILE: /var/www/drupal-7-pareview/pareview_temp/nested_checkbox.module
---------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------
104 | ERROR | [x] Array indentation error, expected 8 spaces but found 10
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/nested_checkbox.js
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | Missing file doc comment
----------------------------------------------------------------------

Those minor coding standard errors are surely not application blockers, please do a real manual review.

This module provides UI to see the nested checkbox.

This would be good if you can write documentation to save values as well.

Manual Review

Individual user account

Yes

No duplication

Yes

Master Branch

Yes

Licensing

Yes

3rd party assets/code

Yes

README.txt/README.md

Yes

Code long/complex enough for review

Yes

Secure code

Yes

Coding style & Drupal API usage

I see no issues. Really clean code. Great work!

This review uses the Project Application Review Template.

Hi Vadim,
I'm sorry it took more time to get reviewed. I had this on my test site for some time, and it works well.

A few suggestions:
- Is there any way to set error to a specific nested check box set? can you show a form_set_error() example?
- It's not really necessary to define the module package as "Other" in the module .info file. Unless you explicitly set one, it will be sent to the Other set anyway.

No blocking issues that I could find about.

Thanks for your contribution, Vadim Valuev!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.