[D7]Dynamic theme

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxgastas1819740git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Tested on latest version of Firefox, IE, Chrome and Safari. Happy to see this project for production if developer fix errors of 'Bad line endings were found' reported by "PA robot" and some css errors found at w3.org validator. Please check this http://jigsaw.w3.org/css-validator/validator?uri=http%3A%2F%2Fthemes.gas....

Manual Review :

(1) page__error.tpl.php

1. unwanted numerics are on line - 1
Example : 123412

2. use l() for links and t() for texts.
Example : line no -180 and 183
Drupal should be l(t('Drupal'),'http://drupal.org')

(2) page.tpl.php

1. use l() for links and t() for texts.
Example : line no -180 and 183
Drupal should be l(t('Drupal'),'http://drupal.org')

(3) js/script.js

1. remove un-wanted code - line no 15 to 19 and line no - 21

General :
Drupal Coding standards are missing (please check the Drupal coding standards).

Thank you for your contribution.

After first enabling the theme on a fresh install of Drupal I get the following errors:

Notice: Undefined index: page_top_dynamic in include() (line 103 of /Users/jnettik/Sites/drupal-7.22/sites/all/themes/dynamic/page.tpl.php).
Notice: Undefined index: sidebar_dynamic in include() (line 160 of /Users/jnettik/Sites/drupal-7.22/sites/all/themes/dynamic/page.tpl.php).
Notice: Undefined index: sidebar_dynamic in include() (line 167 of /Users/jnettik/Sites/drupal-7.22/sites/all/themes/dynamic/page.tpl.php).
Notice: Undefined index: sidebar_dynamic in include() (line 173 of /Users/jnettik/Sites/drupal-7.22/sites/all/themes/dynamic/page.tpl.php).
Notice: Undefined index: end_dynamic in include() (line 210 of /Users/jnettik/Sites/drupal-7.22/sites/all/themes/dynamic/page.tpl.php).

Those regions don't exist in the theme's .info file but still referenced in the page.tpl.php.

Manual Code Review:

template.php
Line 127 has a reference to page__error, however that file no longer exists.

File structure
Not necessary, but I like to put my template files in a templates/ directory, which helps keep the theme root cleaner. Some other contrib themes follow this convention.

Hi gastas,

I manually installed your theme 'dynamic'. I get following errors.

Strict warning: Only variables should be passed by reference in include() (line 87 of D:\Xampp\htdocs\3S\Acta\sites\all\themes\dynamic\templates\page.tpl.php).
Notice: Undefined index: page_top_dynamic in include() (line 103 of D:\Xampp\htdocs\3S\Acta\sites\all\themes\dynamic\templates\page.tpl.php).
Notice: Undefined index: sidebar_dynamic in include() (line 160 of D:\Xampp\htdocs\3S\Acta\sites\all\themes\dynamic\templates\page.tpl.php).
Notice: Undefined index: sidebar_dynamic in include() (line 167 of D:\Xampp\htdocs\3S\Acta\sites\all\themes\dynamic\templates\page.tpl.php).
Notice: Undefined index: sidebar_dynamic in include() (line 173 of D:\Xampp\htdocs\3S\Acta\sites\all\themes\dynamic\templates\page.tpl.php).
Notice: Undefined index: end_dynamic in include() (line 210 of D:\Xampp\htdocs\3S\Acta\sites\all\themes\dynamic\templates\page.tpl.php).

Please fix above errors.
I also attached screenshot for your reference.

Changing status until fix all bugs.

For the integration of Twitter Bootstrap into Drupal, the Base Theme Twitter Bootstrap appears to be a solid option and I will rather recommend to build a subtheme instead of going all the way again with a new base theme.

Page is not showing on 1200px width, styles overwrited on style.css

Do not find TB javascript files, only images and styles.

Documentation does not help, neither readme.txt nor the project page.

Reviewing your templates found this hardcoded info on node--product_display.tpl that actually refers directly to you. This cannot be changed unless you hack this theme file.

  				<div id="fb-root"></div>
  				<script>(function(d, s, id) {
  				  var js, fjs = d.getElementsByTagName(s)[0];
  				  if (d.getElementById(id)) return;
  				  js = d.createElement(s); js.id = id;
  				  js.src = "//connect.facebook.net/ru_RU/all.js#xfbml=1&appId=101270396650282";
  				  fjs.parentNode.insertBefore(js, fjs);
  				}(document, 'script', 'facebook-jssdk'));</script>
  				<div class="fb-like" data-send="true" data-width="450" data-show-faces="true"></div>
  				
  				<a href="https://twitter.com/share" class="twitter-share-button" data-via="gastas">Tweet</a>
  				<script>!function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0],p=/^http:/.test(d.location)?'http':'https';if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src=p+'://platform.twitter.com/widgets.js';fjs.parentNode.insertBefore(js,fjs);}}(document, 'script', 'twitter-wjs');</script>

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.