[D7] PHP Variable Hunter

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Not sure why this is in "needs review"
There are no files, and you're still on the master branch?
Maybe I'm missing something?
~R~

Looks like a neat and useful module (I can remember myself expanding a huge dpm tree and searching it with the browser).
- in your repo, there is a folder with 7.x-1.x-dev name. Put the files in the branch root and a folder name is not necessary.
- Devel module is a de facto to debug stuff, so there is a good chance that the users have Devel module installed. I'd rather prefer a Devel integration so I can debug the stuff well.
Devel module has permission-based debug info display, as well as using Drupal's message system. Printing stuff directly makes it very difficult to use your module to debug an Ajax request.
Devel module does a good job there by adding multiple display methods. dpm, kpr, etc.
- you can use format_plural() to display "1 match found" or "x matches found" text.
- let's also document how to return an array of matches to a variable(describe the internal call function) - this will be very useful to dpm().
- GPL license will be included as a text file when your module gets downloaded from Drupal.org, so including those information is not necessary I think

I'm sorry if I was at the extreme side when mentioning Devel integration. IMO, it's not necessary to patch Devel module and put this nice module into the Devel - but we can definitely make use of Devels features.

For example,
dpm(phpvariable_hunter_internalcall($array, $needle, $exact_match));
Above line will return the results array to dpm() function that we use everyday to see array contacts.

Better yet, if we can create a function like dpvh() that does the same job as above, it will be more convenient I think. But in order to use dpm(), we must make sure dpm() function is available.
To do so, we can check function_exists('dpm'), or add devel as a dependency in the .info file.

If we can alias the internal call function to something smaller (phvr() for example), we can document an easy to use way like dpm(phvr())

However, deciding them is completely up to you. I'm going to be a big fan of this module because I can remember myself clicking the Devel-output tree numerous times. If it can be any quick or requires fewer keystrokes, the better :)

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxjeoware2023153git

I'm a robot and this is an automated message from Project Applications Scraper.

My initial thought is that this should probably be done as a patch to devel. I see you have an issue over there already #2061317: Add phpvariable_hunter … Come to think of it, this module is also too small to warrant a full review.

Hi jeoware,

I agree this is too small to do a full review and grant full project access. We can, however, review this and promote this specific project if you want.

To that end, manual review:

* It's not clear to me why you're using $GLOBALS. It doesn't appear to be necessary, and global scope should only be used when necessary. Could you pass those variables into phpvariable_hunter_results() as parameters, or use drupal_static to make them available globally without putting them in the global scope?
* I think pvh() needs to be namespaced with your module name as a prefix. Yes, devel breaks this rule with dpm(), etc. I'm not sure how we're deciding which modules can get away with that, but in this case, I don't see any good reason for your module to use a prefix that doesn't match your module name. If having pvh() as a function name is important, any reason not to change the module machine name to pvh?
* Why is phpvariable_hunter() making print() calls? It looks like that will dump output wherever it happens to be called in a page render, which would be mostly at the very beginning of a page, before the opening HTML. That seems kind of messy. Could that be returned as part of the response? Or maybe output with drupal_set_message()?

If you had a look at some applications here, you will see there are many applications from experienced users like you but are delayed because of these "Drupal standards".

I started to use phv in some of my test sites and getting used to it.

• Please remove the license from README.txt and the module file, drupal.org will automatically add a LICENSE.txt file for you that specifies GPL2.
• What is $callerinfo = '';? We generally don't allow bare PHP, and I can't find where you are using that.
• Providing drush integration would be really nice
• Have you considered providing a block for the output? Then the user could assign that anywhere they like in whichever theme they like, and not need to mess around with the page template.

I think it's fine to provide a pvh() shortcut.
I reopened and commented on https://drupal.org/node/2061317#comment-7790309 as well.
Setting to needs work for the first 2 issues, which are blocking.

Thanks for those updates! I can't find any blocking issues.

----
Top Shelf Modules - Crafted, Curated, Contributed.

It's been a month without any problems reported, so I'm promoting this myself as per https://drupal.org/node/1125818.

Thanks for your contribution, jeoware!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.