Closed (fixed)
Project:
Views Bulk Operations (VBO)
Version:
6.x-1.15
Component:
Core
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
21 Jun 2013 at 14:31 UTC
Updated:
16 Sep 2013 at 17:47 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
ergonlogicTrivial patch attached.
Comment #2
bojanz commentedCommitted.
Comment #3
roball commentedComment #4
gnassar commentedSince the release bug got marked duplicate to this one, it's worth it to note that it's not really closed until release branch isn't a broken build, as any new install (like mine) will get a crasher on installing what is supposed to be a green, stable build. I'm sure it's on its way, but figured until then better to note that it's still an issue for the next user that comes around.
Comment #5
roball commentedThis critical bug released with VBO 6.x-1.15 has been introduced by the commit reported at #1843166: Support Views 3 Row classes. Seems that the patch has been blindly committed without any testing if it actually works. VBO 6.x-1.16 should be released immediately with the critical changes reverted and ensuring compatibility to Views 2.
Comment #6
roball commentedcrosspost...
Comment #7
roball commented...however the status is in fact fixed in Git.
Comment #8
bojanz commentedI will tag 1.16 tomorrow if you confirm that the current git / -dev version works properly for you.
Comment #9
gnassar commented"patch (to be ported)" is a "fixed" status, isn't it? That's why it shows up as green in the issue queue. Not a big enough deal to get in a push-and-pull over, though. :)
EDIT: installing now. Will putz around with it for a bit and see if anything breaks. Not foreseeing issues.
Comment #10
roball commentedSince people are still posting into the duplicate issue for this bug, I am linking to it: #2025453: Cannot access empty property in views_bulk_operations.module on line 2063
Comment #11
ressaI added the
, $view-part manually in my views_bulk_operations.module just to test, and can confirm that VBO now works.I do get two spinning wheels (
<span class="views-throbbing">) when I select something, but that is probably not related to this issue.Comment #12
gnassar commentedTried about every case I can think of. Can't seem to break the thing. Recommend roll to 1.16.
Comment #13
roball commentedgnassar, so you can confirm the current 6.x-1.x-dev works fine?
Comment #14
quotesbro commented6.x-1.x-dev works.
Comment #15
roball commentedDoes 6.x-1.x-dev also work with Views 6.x-2.x (in addition to Views 6.x-3.x)?
Comment #16
gnassar commentedI actually was testing with Views 6.x-2.x, not 6.x-3.x. Can confirm no issues so far, but somebody else would have to test -3.x.
Comment #17
roball commentedAh, then it's great because the current maintainer (who does not test or use anything on D6 himself) thought that Views 6.x-2.x support may no longer work: #1843166: Support Views 3 Row classes.
Comment #18
gnassar commentedLooking at #1843166, it looks like that patch may in some cases break a bit of theming (EDIT: outside of introducing this particular bug, of course, but that's not at all V6-2 specific), if your theme depends on the HTML classes involved in that patch. This one is a hard crasher. The maintainer did say he'd accept patches for the other; I may do that here at some point (since we are using Views 6.x-2.x specifically because it is the stable supported build), but it's clearly not as big a concern as this is.
Comment #20
anouJust to say that the patch makes pages made by VBO re-appear but all class on TD are gone...
Comment #21
bidu commentedHi,
since I am completely new in drupal, can anybody tell me how I must apply this patch? Is it a copy-past into the module, and if so, where?
Tank you !
Bidu
Comment #22
anou@bidu: normally this patch is already applied to the dev version of the module (I didn't check it...) but if you want to apply the patch yourself, check this page.
Or if you want to apply it "a la mano" :
Have fun!
Comment #23
izmeez commentedJust came across this issue and vbo 6.x-1.15 does not include the commit despite the date showing as June 21. The fix does seem to be in the dev release. Is it possible to have this commit and a new release?
Thanks.
Comment #24
bojanz commentedYou can't retroactively add commits to a release ;)
I suggest using 1.14 until I tag a 1.16.
Comment #25
izmeez commented@bojanz
Yes, I understand you cannot retroactively add commits to release and the dev version includes the fix and I saw there is another issue hoping for the next release 1.16 :-)
Thanks for all your work.
Comment #26
stevenovy commented6.x-1.x-dev worked for us with Views 6.x-2.x.
Comment #27
strae commentedI can confirm that 6.1.x-dev work with Views 6.x-2.16
p.s: thank you guys for continue mantaining a module for a old version ;)
Comment #28
Anonymous (not verified) commentedThanks for this patch. I'm running off the stable branch, applied it, and it works (FYI, stable = security team support). Looking forward to 6.x-1.16.
+1 to what @Strae noted above. Greatly appreciate the support for 6.x series. I'm still a few months from reworking this site into D7.
Comment #29
theohawse commentedHas this been applied to 6.x-1.16?? Need to know as VBO is built into the hostmaster project.
Edit: This appears to be patched in VBO 6.x-1.16 and now working with 6.x-2.0-rc4 version of hostmaster in conjunction with views 6.x-3.x.
Comment #30
helmo commentedYes this is included in 1.16, The hostmaster makefile has now been updated.
Thanks for notifying.