_views_bulk_operations_hash_object() is not passed enough arguments in theme_views_node_selector, resulting in:

PHP Fatal error:  Cannot access empty property in /var/aegir/hostmaster-6.x-2.x/sites/all/modules/views_bulk_operations/views_bulk_operations.module on line 2063, referer: http://aegir2.aegir2.local/admin/build/modules

Patch forthcoming.

Comments

ergonlogic’s picture

Status: Active » Needs review
StatusFileSize
new831 bytes

Trivial patch attached.

bojanz’s picture

Status: Needs review » Fixed

Committed.

roball’s picture

Priority: Major » Critical
gnassar’s picture

Version: 6.x-1.x-dev » 6.x-1.15
Status: Fixed » Patch (to be ported)

Since the release bug got marked duplicate to this one, it's worth it to note that it's not really closed until release branch isn't a broken build, as any new install (like mine) will get a crasher on installing what is supposed to be a green, stable build. I'm sure it's on its way, but figured until then better to note that it's still an issue for the next user that comes around.

roball’s picture

Status: Patch (to be ported) » Fixed

This critical bug released with VBO 6.x-1.15 has been introduced by the commit reported at #1843166: Support Views 3 Row classes. Seems that the patch has been blindly committed without any testing if it actually works. VBO 6.x-1.16 should be released immediately with the critical changes reverted and ensuring compatibility to Views 2.

roball’s picture

Status: Fixed » Patch (to be ported)

crosspost...

roball’s picture

Status: Patch (to be ported) » Fixed

...however the status is in fact fixed in Git.

bojanz’s picture

I will tag 1.16 tomorrow if you confirm that the current git / -dev version works properly for you.

gnassar’s picture

"patch (to be ported)" is a "fixed" status, isn't it? That's why it shows up as green in the issue queue. Not a big enough deal to get in a push-and-pull over, though. :)
EDIT: installing now. Will putz around with it for a bit and see if anything breaks. Not foreseeing issues.

roball’s picture

Since people are still posting into the duplicate issue for this bug, I am linking to it: #2025453: Cannot access empty property in views_bulk_operations.module on line 2063

ressa’s picture

I added the , $view-part manually in my views_bulk_operations.module just to test, and can confirm that VBO now works.

I do get two spinning wheels (<span class="views-throbbing">) when I select something, but that is probably not related to this issue.

gnassar’s picture

Tried about every case I can think of. Can't seem to break the thing. Recommend roll to 1.16.

roball’s picture

gnassar, so you can confirm the current 6.x-1.x-dev works fine?

quotesbro’s picture

6.x-1.x-dev works.

roball’s picture

Does 6.x-1.x-dev also work with Views 6.x-2.x (in addition to Views 6.x-3.x)?

gnassar’s picture

I actually was testing with Views 6.x-2.x, not 6.x-3.x. Can confirm no issues so far, but somebody else would have to test -3.x.

roball’s picture

Component: Theming » Core

Ah, then it's great because the current maintainer (who does not test or use anything on D6 himself) thought that Views 6.x-2.x support may no longer work: #1843166: Support Views 3 Row classes.

gnassar’s picture

Looking at #1843166, it looks like that patch may in some cases break a bit of theming (EDIT: outside of introducing this particular bug, of course, but that's not at all V6-2 specific), if your theme depends on the HTML classes involved in that patch. This one is a hard crasher. The maintainer did say he'd accept patches for the other; I may do that here at some point (since we are using Views 6.x-2.x specifically because it is the stable supported build), but it's clearly not as big a concern as this is.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

anou’s picture

Just to say that the patch makes pages made by VBO re-appear but all class on TD are gone...

bidu’s picture

Hi,

since I am completely new in drupal, can anybody tell me how I must apply this patch? Is it a copy-past into the module, and if so, where?

Tank you !
Bidu

anou’s picture

@bidu: normally this patch is already applied to the dev version of the module (I didn't check it...) but if you want to apply the patch yourself, check this page.
Or if you want to apply it "a la mano" :

  1. open the .patch file
  2. line 1 you'll see which file of the module is modified (views_bulk_operations.module)
  3. line 4 you'll see wich function is modified (theme_views_node_selector($element))
  4. and line 8 and 9 you'll see respectively a "-" (minus) and a "+" (plus) sign. This means that line 9 replaces line 8.
  5. save your changes

Have fun!

izmeez’s picture

Just came across this issue and vbo 6.x-1.15 does not include the commit despite the date showing as June 21. The fix does seem to be in the dev release. Is it possible to have this commit and a new release?

Thanks.

bojanz’s picture

You can't retroactively add commits to a release ;)
I suggest using 1.14 until I tag a 1.16.

izmeez’s picture

@bojanz
Yes, I understand you cannot retroactively add commits to release and the dev version includes the fix and I saw there is another issue hoping for the next release 1.16 :-)

Thanks for all your work.

stevenovy’s picture

6.x-1.x-dev worked for us with Views 6.x-2.x.

strae’s picture

I can confirm that 6.1.x-dev work with Views 6.x-2.16

p.s: thank you guys for continue mantaining a module for a old version ;)

Anonymous’s picture

Thanks for this patch. I'm running off the stable branch, applied it, and it works (FYI, stable = security team support). Looking forward to 6.x-1.16.

+1 to what @Strae noted above. Greatly appreciate the support for 6.x series. I'm still a few months from reworking this site into D7.

theohawse’s picture

Has this been applied to 6.x-1.16?? Need to know as VBO is built into the hostmaster project.

Edit: This appears to be patched in VBO 6.x-1.16 and now working with 6.x-2.0-rc4 version of hostmaster in conjunction with views 6.x-3.x.

helmo’s picture

Yes this is included in 1.16, The hostmaster makefile has now been updated.

Thanks for notifying.