[D7] Clean markup

Hello!

Please, take a look at Ventral report and fix the errors - http://ventral.org/pareview/httpgitdrupalorgsandboxrhache1805074git

clean_markup.info

files should be used for classes or interfaces declarations, not for .module files. Same for other .info files. (https://drupal.org/node/542202)

clean_markup_blocks.install

Please, add variable_del('clean_markup_blocks-defaults') to hook_uninstall().

clean_markup_blocks.module

Might be a good move to split hook_form_alter() into two individual hook_form_FORM_ID_alter(), since we care about only 2 forms.

Thank you.

Nice work. [=

I need to modify both forms with the same code, which is why I chose to do it the way I did, rather than creating two hook_form_FORM_ID_alter() functions and copy-pasting the exact same code, so I'm going to ignore this.

No need to duplicate the code. You can use common function with code, which hook_form_alter() holds right now and pass $form and $form_state by reference (e.g. &$form) in each hook_form_FORM_ID_alter().

function clean_markup_blocks_form_block_admin_configure_alter(&$form, &$form_state) {
  _clean_markup_blocks_form_common(&$form, &$form_state);
}

So each hook_form_FORM_ID_alter() will use the same exact code and it will be called only with these two forms.

Hello,

In regards to the comments, looking at the standars for comments a comment for a function looks something like

/**
 * Sample summary line.
 *
 * Next paragraph. Etc.
 */
(code being documented goes here, such as a function declaration, class, etc.)

So the summary line should be short, hence the one line limit, and then a longer description can follow that.

I couldn't find any major issues with your code.

Good luck

+1

Adding bio for myself

I enabled and tested your module on a test site. Here are some notes:

(1) In this issue description, you should set the git clone instructions to:

git clone --branch 7.x-2.x http://git.drupal.org/sandbox/rhache/1805074.git clean_markup

instead of

git clone --branch 7.x-2.x http://git.drupal.org/sandbox/rhache/1805074.git

Otherwise we end up with a folder entitled 1805074 rather than one entitled clean_markup.

(2) The module works as advertised for blocks. I don't use panels so I could not test the panels submodule. From what I gather you are using the Drupal API correctly.

(3) Many users use the context module to import and export block placements between environments. Your module works well with contexts, and, because your settings are stored as variables, they can easily be imported and exported using the strongarm and features modules. This makes your module ready for a dev-stage-production workflow, not strictly necessary but appreciated by a growing number of users.

I'm setting this to RTBC as I believe it's ready for full module status.

Cheers,

Albert.