Mis-named variables in picture_theme() [#2026319]

This issue is to fix failing test - https://drupal.org/node/2009662#comment-7569357. The changes below are out of scope for 'Replace theme() with drupal_render() in picture module'

Undefined index: uri
Undefined index: dimensions

     'picture' => array(
       'variables' => array(
         'style_name' => NULL,
-        'path' => NULL,
+        'uri' => NULL,
         'width' => NULL,
         'height' => NULL,
         'alt' => '',
@@ -163,7 +163,7 @@ function picture_theme() {
       'variables' => array(
         'src' => NULL,
         'srcset' => NULL,
-        'dimension' => NULL,
+        'dimensions' => NULL,
         'media' => NULL,

Comment	File	Size	Author
#1	undefined-variables-2026319-1.patch	689 bytes	pplantinga

Comments

Status	File	Size
new	undefined-variables-2026319-1.patch	689 bytes

Comment #2

pplantinga commented 2 July 2013 at 01:15

Status:

Active

» Needs review

Oh yeah, status.

Comment #3

pplantinga commented 16 July 2013 at 23:05

Title:

Undefined index: uri and Undefined index: dimensions in picture.module

» Mis-named variables in picture_theme()

Updated title to be more cause and less effect. Can someone take a look at it, it's blocking #2009662: [REGRESSION] Replace theme() with drupal_render() in picture module ?

Comment #4

thedavidmeister commented 20 July 2013 at 14:51

Assigned:	pwieck	» Unassigned
Issue tags:		+theme system cleanup

Comment #5

thedavidmeister commented 20 July 2013 at 14:55

I can confirm that 'uri' looks like the correct variable name for theme_picture(), not only is it actually used in theme_picture() but it is passed to theme_image_style() which is looking for $variables['uri'] too.