As we used hook_node_operations() to provide the VBO site tasks/operations, the operations also show up on the standard Node admin page (admin/content/node). This causes confusion as the site 'Delete' task shows up identically to the node 'Delete' operation.

Comments

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Active » Needs review

Simple solution:
- Site node operations are prefixed with "Site: "
- View implementing site node operations overrides the labels.

Repo: http://drupalcode.org/sandbox/deciphered/2001932.git/shortlog/refs/heads...
Patch: http://drupalcode.org/sandbox/deciphered/2001932.git/patch/00c067f2fdb4a...

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Status: Needs review » Fixed

Fixed in 914aadd.

I also removed the 'delete backups' operation, as it was failing for lack of arguments.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

Good good, I was going to open another issue about that at some stage, as that one expects BIDs as arguments not NIDs, so either it needs an interface, or some additional logic to load all BIDs related to the provided NIDs.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Fixed » Active

This commit seems to be missing... Not pushed?

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Status: Active » Fixed

Ah, sorry! pushed.

Re. 'delete-backups', I may re-introduce some of that code, as it conveniently results in #1975086: tasks sometimes are marked as running when they have in fact crashed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 914aadd on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by ergonlogic: 
    Issue #2026417: Disambiguate site operations.

  • Commit 914aadd on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by ergonlogic: 
    Issue #2026417: Disambiguate site operations.