Comments

blueminds’s picture

Status: Active » Needs review
StatusFileSize
new1.05 KB

Please see the patch

blueminds’s picture

StatusFileSize
new1.15 KB

I guess with comment it will be better

berdir’s picture

Status: Needs review » Needs work
+++ b/ui/tmgmt_ui.moduleundefined
@@ -511,6 +511,10 @@ function _tmgmt_ui_review_form_element(&$form_state, $data, TMGMTJobItem $job_it
+  // Set ajaxid into $form_state so that it is available in
+  // reviewDataItemElement() callbacks.
+  $form_state['ajaxid'] = $form['#ajaxid'];

As $form_state is the global state, I'd rather repeat this in each element or pass it as a separate argument.

Seems like we're missing a bit of context in that function anyway, maybe pass in $key and $parent_key explicitly as new arguments and and just recalculate the id there? Maybe provide a helper function.

blueminds’s picture

Status: Needs work » Needs review
StatusFileSize
new5.34 KB
new8.63 KB

please see the patch

Status: Needs review » Needs work

The last submitted patch, tmgmt-review_form-2026825-3.patch, failed testing.

berdir’s picture

Status: Needs work » Needs review
StatusFileSize
new5.34 KB

Re-upload of the interdiff, I think that's the patch that we want here :)

Status: Needs review » Needs work

The last submitted patch, tmgmt-review_form-2026825-3.patch, failed testing.

blueminds’s picture

Status: Needs work » Needs review
StatusFileSize
new5.83 KB

the patch contained code already committed, rerolled.

berdir’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.