Small followup of Issue #1970740
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | tmgmt-review_form-2026825-4.patch | 5.83 KB | blueminds |
| #6 | tmgmt-review_form-2026825-3.patch | 5.34 KB | berdir |
| #4 | tmgmt-review_form-2026825-3.patch | 8.63 KB | blueminds |
| #4 | tmgmt-review_form-2026825-3.interdiff.txt | 5.34 KB | blueminds |
| #2 | tmgmt-review_form-2026825-2.patch | 1.15 KB | blueminds |
Comments
Comment #1
blueminds commentedPlease see the patch
Comment #2
blueminds commentedI guess with comment it will be better
Comment #3
berdirAs $form_state is the global state, I'd rather repeat this in each element or pass it as a separate argument.
Seems like we're missing a bit of context in that function anyway, maybe pass in $key and $parent_key explicitly as new arguments and and just recalculate the id there? Maybe provide a helper function.
Comment #4
blueminds commentedplease see the patch
Comment #6
berdirRe-upload of the interdiff, I think that's the patch that we want here :)
Comment #8
blueminds commentedthe patch contained code already committed, rerolled.
Comment #9
berdirCommitted and pushed. Opened #2032263: Add tests for review/reject form interations.