Formatter for location fields. Allows showing/hiding of location field information for individual view modes. A node might wish to show the complete location in full view mode, but only the city and state in teaser mode. Defaults to field settings for location display.

Drupal core version: 7.x
Project page: https://drupal.org/sandbox/mattsharkey/2026969
Git repository: git.drupal.org:sandbox/mattsharkey/2026969.git

Comments

Vasiliy Grotov’s picture

Vasiliy Grotov commented
Status: Needs review » Needs work

Hello.

Please, remove master branch with version-named one.

location_field_names() function is missing.

location_custom_display.info

files should be used for classes or interfaces declarations, not for .module files. (https://drupal.org/node/542202)

location_custom_display.module

location_custom_display_field_formatter_info()

  • Wrap label into t().

Thanks.

mattsharkey’s picture

mattsharkey commented
Status: Needs work » Needs review

The location_field_names function is a part of the location module, which is a dependency for this module. I've explicitly included it where it is used, just in case.

Everything else should be done. Thanks!

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxmattsharkey2026969git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

jyokum’s picture

jyokum commented

location_custom_display.module

location_custom_display_field_formatter_settings_form

return value of 'None' should be wrapped in t() as well.

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.