[D7] Term menus

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxsmiletrl2027003git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Nice code! It's nice code. But overall the module has spellingmisstakes and some grammar that should be looked at. Fixing those will make it great imo.

Examples of grammar and spelling

Spelling errors in readme:

1. Install this module as usual way for mmost Drupal modules.
2. it doesn't inlcude child

Spelling errors in module

• "his is a lightwieght function t" in module line 910
• Grammar in this text should be looked at "This list shows all term menus in site.
  There're no term menus enabled in site now. You may enable term menu for taxonomy field at taxonomy field's editing page, e.g., admin/structure/types/manage/article/fields/field_test_term". Should be something likeThere's no term menus enabled in this site now. ...

term_menu hook

This should describe what the link does for the user. Not what the module use it for.

'description' => 'Provide a central place to see term meu list.', should perhaps be "Administration of menu term lists"

Field settings

The grammar makes the settings confusing. examples:

• "Whether terms inside this term menu uses custom term menu page"
• "Whether synchronize term menu when a node is updated."
• "Whether synchronize term menu when term(s) get updated".

Changed status

Updated issue summary.

Hi again!

There are a number of variables that has been left from development that seems to me are not being used:

//term_menus_field_menu_validate()
$field_name = $form['#field']['field_name'];
  $field = $form['#field'];

//term_menus_tokens() 
$sanitize = !empty($options['sanitize']);//never used?

//term_menus_insert_term_path_alias()
//term_menus_insert_term_path_alias()
//Alias is never used
$alias = pathauto_create_alias('term_menus', 'update', $source, $data, $term_menu->field_name);

//term_menus_taxonomy_vocabulary_delete()
  $menu['menu_name'] = $term_menu->menu_name;//this line?
    _term_menus_delete_menu($term_menu);

 * Implements hook_node_insert().
 *
 * Add this node into term menu, if condition is met.
 */
function term_menus_node_insert($node) {
  _term_menu_insert_node_link($node);// this function does not exist!
}

Updated issue summary.

Already Approved

It appears that you have successfully completed the application process with a different application, and been granted the 'create full projects' permission:

Project: https://drupal.org/node/1800798

Once their first application has been successfully approved, then an applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue.

With this in mind, I have marked your application as 'closed(duplicate)'. If this is incorrect, and you do not yet have the ability to create full projects, then please feel free to re-open this application.

Updated issue summary.