#111715: Convert node/content types into configuration landed. #2029405: Write configuration schema for node types is open to write schemas. Once schemas are there, we would only need to wire them in to config translation I think. Even before that, we could add the list controller support, even if it would not work due to missing schema.

CommentFileSizeAuthor
#8 2029407-node-type-8.patch2.76 KBshnark
#7 2029407-node-type-7.patch0 bytesshnark
#7 interdiff-6-7.txt3.15 KBshnark
#6 2029407-node-type-6.patch556 bytesshnark
#1 2029407-node-type-1.patch590 bytesvijaycs85

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Active » Needs review
StatusFileSize
new 2029407-node-type-1.patch590 bytes

Initial patch...

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Issue tags: -D8MI, -language-config

#1: 2029407-node-type-1.patch queued for re-testing.

vijaycs85’s picture

vijaycs85
Location London, UK
commented

#1: 2029407-node-type-1.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +D8MI, +language-config

The last submitted patch, 2029407-node-type-1.patch, failed testing.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Should also expand listing tests in the module :)

shnark’s picture

shnark commented
Status: Needs work » Needs review
StatusFileSize
new 2029407-node-type-6.patch556 bytes

Reroll. The context lines were messed up, but the bottom one was still there so I could line it up.
next I'm going to try to expand the listing tests like mentioned in comment #5, I've never done tests before, so I don't know if I'll get through it.

shnark’s picture

shnark commented
StatusFileSize
new interdiff-6-7.txt3.15 KB
new 2029407-node-type-7.patch0 bytes

I wrote the test, using the format from the other tests in that same file.
I also moved something from the other patch so it was in alphabetical order.

shnark’s picture

shnark commented
StatusFileSize
new 2029407-node-type-8.patch2.76 KB

Sorry, I didn't diff against the right thing.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Fixed

Yay, looks amazing! Committed this! Also added you to the commit message line in #1952394: Add configuration translation user interface module in core. Thanks for working on this!

Automatically closed -- issue fixed for 2 weeks with no activity.