Problem
On installing webform2pdf You may get this error if you download TCPDF latest version or any version from 6.0.000 onwards.
I looked at theTCPDF commit browser and it looks that private property $tcpdf_version and getter method getTCPDFVersion() has been removed from 6.0 branch at all.
Solution;
1. Readme file should be updated with relevant TCPDF versions that are supported
2. webform2pdf.install should be amended for better error handling providing if statement for checking existence of :getTCPDFVersion().
I've created patch to resolve these errors and updated readme file and comment sections in code. In addition to code errors patch fixes couple of code formating issues either.
Any help with testing would be much appreciated.
Conclusion
Nevertheless I think this is quick fix only I'd say hook_requirements should have better implementaion;
- Getting rid of variable get, we use libraries
- Displaying Requirements OK message is all checks have been passed, eg correct TCPDF downloaded and placed under sites/all/libraries
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | issue-2029527-3-webform2pdf.install.fatal_error.patch | 747 bytes | mr.york |
| webform2pdf.install.fatal_.error_.patch | 19.35 KB | pasive |
Comments
Comment #1
jaxxed commentedtesting patch
Comment #2
jaxxed commentedI'll reformat the patch for 3.x-dev
Comment #3
mr.york commentedFixed TCPDF version detect.
Comment #4
pasive commentedThanks @mr.york your patch #3 works fine for me.
Comment #5
houstonaplus commented#3 also worked for me. This fix needs to pushed to the stable version.
Comment #6
TBarina commentedSubscribe. #3 works.
Comment #7
cafuego commentedThe patch from #3 works nicely.
Comment #7.0
cafuego commentedTypos
Comment #8
mr.york commentedCommited.