Problem

On installing webform2pdf You may get this error if you download TCPDF latest version or any version from 6.0.000 onwards.

I looked at theTCPDF commit browser and it looks that private property $tcpdf_version and getter method getTCPDFVersion() has been removed from 6.0 branch at all.

Solution;

1. Readme file should be updated with relevant TCPDF versions that are supported
2. webform2pdf.install should be amended for better error handling providing if statement for checking existence of :getTCPDFVersion().

I've created patch to resolve these errors and updated readme file and comment sections in code. In addition to code errors patch fixes couple of code formating issues either.

Any help with testing would be much appreciated.

Conclusion

Nevertheless I think this is quick fix only I'd say hook_requirements should have better implementaion;

  1. Getting rid of variable get, we use libraries
  2. Displaying Requirements OK message is all checks have been passed, eg correct TCPDF downloaded and placed under sites/all/libraries

Comments

jaxxed’s picture

Status: Active » Needs review

testing patch

jaxxed’s picture

Status: Needs review » Needs work

I'll reformat the patch for 3.x-dev

mr.york’s picture

Status: Needs work » Needs review
StatusFileSize
new747 bytes

Fixed TCPDF version detect.

pasive’s picture

Thanks @mr.york your patch #3 works fine for me.

houstonaplus’s picture

#3 also worked for me. This fix needs to pushed to the stable version.

TBarina’s picture

Subscribe. #3 works.

cafuego’s picture

Version: 7.x-3.0 » 7.x-3.x-dev
Status: Needs review » Reviewed & tested by the community

The patch from #3 works nicely.

cafuego’s picture

Issue summary: View changes

Typos

mr.york’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Commited.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.