Theme container adds a div around something. We will be using this for many, many things in core, not just form elements, so it should be moved out of form.inc and into theme.inc.

Here are examples of some things that will be using theme_container:

  • theme_more_link
  • theme_system_compact_link
  • theme_more_help_link
  • @todo more
CommentFileSizeAuthor
#1 core-move_theme_container-2031341-1.patch2.53 KBjenlampton
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Status: Active » Needs review
FileSize
core-move_theme_container-2031341-1.patch2.53 KB

This may be a blocker for #1595614: [meta] Remove all the theme functions and templates in core that simply output a link. Replace with #type 'link' render arrays

ericrdb’s picture

ericrdb CreditAttribution: ericrdb commented
Status: Needs review » Reviewed & tested by the community

Patch applied, then added forum post, aggregation and content.

Confirmed that there is a More link wrapped by a div

on all the above content blocks.

Also, in admin/structure/forum The More Help link is wrapped by a div class "more-help-link"

More to test on this?

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Priority: Normal » Major

I think this is blocking these issues (which need to be in today?), so bumping up priority:

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.