a commonly used word in e-commerce & sorting features.

CommentFileSizeAuthor
add_context_to_order.patch1.21 KBdroplet

Comments

droplet’s picture

droplet commented
Issue tags: +string context

tagging

jamesliu78’s picture

jamesliu78
Primary language Chinese, Traditional
commented

Also find similar problems in:
core/modules/views/lib/Drupal/views/Plugin/views/exposed_form/ExposedFormPluginBase.php: Line 221

droplet’s picture

droplet commented

@jamesliu78,

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/exposed_form/ExposedFormPluginBase.phpundefined
@@ -218,7 +218,7 @@ public function exposedFormAlter(&$form, &$form_state) {
+          '#title' => t('Order', array(), array('context' => 'Sort order')),

Yeah, this patch includes the string ?

jamesliu78’s picture

jamesliu78
Primary language Chinese, Traditional
commented

@droplet
Oh, sorry. :)

Tor Arne Thune’s picture

Tor Arne Thune commented
Status: Needs review » Reviewed & tested by the community

Looks good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 1470854 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes

Follow-up to fix it in views #3064523: Add t() context to "Order" string for views module