After upgrading Drupal + Media module the widget is behaving oddly. See screenshot.

CommentFileSizeAuthor
#18 2032255-media-file-selector-17.patch908 bytesJeromeChance
#12 media-media-file-selector-2032255-12.patch960 bytesmarkhalliwell
#7 media-media-file-selector-2032255-7.patch978 bytesmarkhalliwell
#5 2032255-4-media-widget-window-sizing.patch604 bytesrandallknutson
media_browsser_sizing.png44.58 KBallard.schipper

Comments

gmclelland’s picture

gmclelland commented
Priority: Major » Normal
Status: Active » Postponed (maintainer needs more info)

Can you provide more details? what OS, browser, theme?

I'm not experiencing this with the latest devs. Maybe you should try those and see if it is fixed?

jdidelet’s picture

jdidelet commented

Same problem. Tested on Firefox, Chrome on Linux and Mac. Seems to have problem on the js file on the div with the classes "ui-dialog ui-widget ui-widget-content ui-corner-all media-wrapper". The position left and top is set to 0.

And the the iframe #mediaBrowser don't fit properly his parent's div.

jdidelet’s picture

jdidelet commented

Ok the problems seems to come with jquery version. I'm using jquery_update module to update jquery version to 1.8 and this bug appear. With jquery version 1.5 or 1.7, I don't have this bug.

randallknutson’s picture

randallknutson commented
Status: Postponed (maintainer needs more info) » Active

I think this has to do with this change to jquery ui tabs: http://jqueryui.com/upgrade-guide/1.9/#deprecated-show-event-renamed-to-...

When I change line 28 of media.browser.js to activate instead of show it seems to work again.

randallknutson’s picture

randallknutson commented
Status: Active » Needs review
StatusFileSize
new 2032255-4-media-widget-window-sizing.patch604 bytes

Here is a patch that supports both versions of jquery ui.

Status: Needs review » Needs work

The last submitted patch, 2032255-4-media-widget-window-sizing.patch, failed testing.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new media-media-file-selector-2032255-7.patch978 bytes

Reroll patch?

Status: Needs review » Needs work

The last submitted patch, media-media-file-selector-2032255-7.patch, failed testing.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Version: 7.x-2.0-unstable7 » 7.x-2.x-dev
Status: Needs work » Needs review

Ah, changing the version to test against.

markhalliwell’s picture

markhalliwell
Primary language English
commented

#7: media-media-file-selector-2032255-7.patch queued for re-testing.

HaloFX’s picture

HaloFX commented
Status: Needs review » Needs work

Unable to able patch.

> error: patch failed: js/media.browser.js:25
> error: js/media.browser.js: patch does not apply

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new media-media-file-selector-2032255-12.patch960 bytes

Reroll

markhalliwell’s picture

markhalliwell
Primary language English
commented
Priority: Normal » Critical

Also bumping this to crit because it makes this module seemingly completely unusable if using jQuery UI 1.9+

aaron’s picture

aaron commented
Status: Needs review » Reviewed & tested by the community

This works for me.

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented

Marked https://drupal.org/node/1957812 as a duplicate of this, which contained an almost identical patch by OnkelTem

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Fixed

Committed #12 to 7.x-2.x. http://drupalcode.org/project/media.git/commit/e2625ed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

JeromeChance’s picture

JeromeChance commented
Issue summary: View changes
StatusFileSize
new 2032255-media-file-selector-17.patch908 bytes

Slight tweak to patch #12. Note this is from a different commit hash (9583d89). Not from HEAD. I needed this for a very specific edge case. --DO NOT USE.