Closed (fixed)
Project:
Node Reminder
Version:
7.x-1.2
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
1 Jul 2013 at 20:11 UTC
Updated:
18 Feb 2014 at 08:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mralexho commentedI've updated the code to include the hour, minutes, and seconds into offset -
strtotime(date('Y-m-d H:i:s', $reminder->from_date)Attached patch.
Thanks,
Alex
Comment #2
mralexho commentedSorry, my previous patch contained extra line insertions because Sublime stripped whitespaces and converted tabs into spaces.
Please use the clean attached patch instead.
Thanks,
Alex
Comment #3
fizk commentedFixed, thanks mralexho!
http://drupalcode.org/project/node_reminder.git/commit/6cf1b4fd9927bc8e7...
http://drupalcode.org/project/node_reminder.git/commit/b1ee9ff324479e6c9...
Comment #4
fizk commentedComment #6
Alpinist1974 commentedHi,
I'm reopening this issue because the module is not working for me. The time offset is not computed. No matter what I enter, the message is sent as soon as cron runs next.
I tried uninstalling and using 7.x-1.1, but no luck with that either. Is there some other configuration option I'm missing here? I hate to be clueless, but in the absence of documentation or even a readme, there's not much I can draw on.
The concept of the module is great, and less clunky than date reminder, but I just can't get it to work.
Any help greatly appreciated!
Thanks,
Matt
Comment #7
mralexho commentedHi Alpinist1974,
Can you post some more information on the offset error? Are you able to see your timestamp in the
node_remindertable? Is your timezone settings set in PHP?Thanks,
Alex
@mralexho
Comment #8
Alpinist1974 commentedHi Alex,
The node_reminder table is saving the timestamp. The PHP settings--in the php.ini--are set to date.timezone = UTC. These are also configured in my Drupal installation.
Thanks,
Matt
Comment #9
mralexho commentedThanks Matt, I'm getting the same error as well.
You can temporarily use the 7.x-1.1 branch and checkout commit 6cf1b4f. I'm running this version on a production site so I know it's working.
*note, the Reminder option does not yet
I'll need to review the code from fizk and see if I can patch the issue.
Alex
Comment #10
Alpinist1974 commentedThanks, Alex,
I'll check out the patch.
Matt
Comment #11
mralexho commentedHi Matt and Yonas,
Please see my attached patch. There was a typo with the reminder object,
reminder_onchanged toreminder_enabledaccording to your schema.I hope you don't mind, I also reordered the
$reminderclass to match the install file.Thanks,
Alex
Comment #12
fizk commentedFixed! Thanks again Alex :)
http://drupalcode.org/project/node_reminder.git/commit/7fb76052a1e46ce59...
@Alpinist1974, I think your issue is related to #2117737: DB query incorrect when checking timestamp