See the attached screenshot.

When I click on "Manage Display" for my content type, I see the Hello World message.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

donaldwbabcock’s picture

Version: 7.x-1.x-dev » 7.x-1.1

This is affects 7.x-1.1 as well.

The code producing the issue is in invisimail.module line 454.

/**
 * Implements callback_field_formatter_settings_summary().
 */
function invisimail_field_formatter_settings_summary($field, $instance, $view_mode) {
  $display = $instance['display'][$view_mode];
  $settings = $display['settings'];

  $summary = '';

  if ($display['type'] == 'invisimail') {
    $encoder = invisimail_get_encoder($settings['encoder']);
    $summary = t('Email addresses will be encoded using the %encoder encoder.', array('%encoder' => $encoder['label']));
  }

  return t('Hello world');
}

Did the maintainer intend to tell the "field formating" user something here?

harshil.maradiya’s picture

Issue summary: View changes
FileSize
923 bytes

Issue is solved now you will be able to see proper label of each formatter

harshil.maradiya’s picture

Status: Active » Needs review
gmclelland’s picture

Status: Needs review » Reviewed & tested by the community

Patch works for me. Thank you

harshil.maradiya’s picture

Thank you so much :) gmclelland

Crell’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/invisimail.module
@@ -1,7 +1,10 @@
+/**
+ * Module name constant
+ */
+define('MODULE_NAME',"invisimail");

This won't work. If 2 modules on the same site both use this approach, kaboom.

The actual bug here is an oops on my part. :-) But the patch would introduce a ptential fatal error, which is a step down.

harshil.maradiya’s picture

Thanks Crell,

Will update my code and will apply new patch.

Cheers,
Harshil Maradiya

harshil.maradiya’s picture

harshil.maradiya’s picture

Status: Needs work » Needs review
Crell’s picture

Er, no. What's with the constant? We don't need a constant, period.

harshil.maradiya’s picture

Hello Crell,

Thank you for your feedback and patience again, I have induced changes as per your comment.

Cheers,
Harshil Maradiya

Crell’s picture

Status: Needs review » Fixed

Committed. Thanks!

harshil.maradiya’s picture

Thanks Crell

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.