[D7] Omnikassa

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxdutchyoda1483516git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

You should use an install file to delete your variables. Create a file named omnikassa.info, and add:

function omnikassa_uninstall() {
  variable_del('omnikassa_merchant_id');
  variable_del('omnikassa_key_version');
  ..........
}

Maybe you didn't have it then, it's a 1 month old post.

Project page

Please take a moment to make your project page follow tips for a great project page.

You have some style errors reported at http://pareview.sh/pareview/httpgitdrupalorgsandboxdutchyoda1483516git, but nothing major.
The code looks pretty good, I can't find any issues. Setting to needs work for a better project page, but otherwise this is RTBC from me.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Thanks for those updates, looks good to me!

----
Top Shelf Modules - Crafted, Curated, Contributed.

It's been a month without any problems reported, so I'm promoting this myself as per https://drupal.org/node/1125818.

Thanks for your contribution, dutchyoda!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.