Hello guys,

It would be nice if we add a new column to commerce_discount table in order to handle label for discount component price. That way, administrator can specify a discount label and it will be shown into order review instead of classic "discount" label.

CommentFileSizeAuthor
#6 commerce_discount-component_price_names-2034685-6.patch6.13 KBjkuma
#5 commerce_discount-component_price_names-2034685-5.patch6.61 KBjkuma
#4 commerce_discount-component_price_names-2034685-4.patch9.2 KBjkuma
#3 commerce_discount-component_price_names-2034685-3.patch9.2 KBjkuma

Comments

jkuma’s picture

jkuma commented
Assigned: Unassigned » jkuma
jkuma’s picture

jkuma commented
Status: Active » Needs work
jkuma’s picture

jkuma commented
Status: Needs work » Needs review
StatusFileSize
new commerce_discount-component_price_names-2034685-3.patch9.2 KB

Here is an attempt to solve this feature request. From my perspective, that patch solves the issue without altering commerce_price.

jkuma’s picture

jkuma commented
StatusFileSize
new commerce_discount-component_price_names-2034685-4.patch9.2 KB

Small wording changes

jkuma’s picture

jkuma commented
StatusFileSize
new commerce_discount-component_price_names-2034685-5.patch6.61 KB

Remove useless parameters, the component title is checked in commerce_discount_add_price component(), if that one is empty, "Discount" is shown.

jkuma’s picture

jkuma commented
StatusFileSize
new commerce_discount-component_price_names-2034685-6.patch6.13 KB

Final attempt.

jkuma’s picture

jkuma commented
Status: Needs review » Fixed

Committed in 7.x-1.x-dev branch. Thanks bojanz for the review.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

The last submitted patch, 3: commerce_discount-component_price_names-2034685-3.patch, failed testing.

The last submitted patch, 4: commerce_discount-component_price_names-2034685-4.patch, failed testing.