[D7] Views App Folders

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Some error found in http://ventral.org/pareview/httpgitdrupalorgsandboxquintux2034595git

FILE: ...7-pareview/pareview_temp/views_app_folders_plugin_style_app_folders.inc
--------------------------------------------------------------------------------
FOUND 6 ERROR(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
13 | ERROR | Class name must begin with a capital letter
13 | ERROR | Class name must use UpperCamel naming without underscores
17 | ERROR | Method name
| | "views_app_folders_plugin_style_app_folders::option_definition"
| | is not in lowerCamel format, it must not contain underscores
17 | ERROR | No scope modifier specified for function "option_definition"
31 | ERROR | Method name
| | "views_app_folders_plugin_style_app_folders::options_form" is not
| | in lowerCamel format, it must not contain underscores
31 | ERROR | No scope modifier specified for function "options_form"
--------------------------------------------------------------------------------

Manual review:
Cannot find anything except the Drupal style issues. Nice work.

Minor coding standard errors are not application blockers, please do a real manual review.

As @klausi mentioned above, those coding standard errors are not application blockers.

views_object::option_definition and option_form are from views API

Maybe you can check the following:

ref: https://api.drupal.org/api/views/includes%21base.inc/function/views_obje...

https://api.drupal.org/api/views/includes%21base.inc/function/views_obje...

Hi !

This is a manual review of your 7.x-1.x branch :

=> Congratulation on it as it working like a charm and is very well written.

* In the readme file I don't find foolowing line very self-explanatory :
1. Create a content type with the right fields.
What are the "right fields" ? => It's working with any field (No need of image for the thumbnails...).

* You shoudn't invite to modify the css that way : "Example CSS - Feel free to change or delete if necessary." as non expert user could just modify the file from there instead of using their theme. They will have a surprise at module update.

I have found nothing strange on the code. Again bravo.
Just modify the two minor stuff there, and I'll set this to "reviewed and tested by the community".

Best !

PS : Feature request => What if I want an image thumbnail PLUS another field to be display at first ? :-)

Hello, This is a manual review of your 7.x-1.x branch:

To begin with, this display plugin looks great! After getting things configured, I found no problems. That said, on the way there, I identified a few things that could be improved:

• The sandbox page could use the copy you have in the readme file to better explain the module's functionality and use.
• Views defaults to the "content" row style, but your display plugin can only display fields. As such, the view output is initially blank; I would suggest displaying an error message or some other feedback to the user when fields are not the chosen row style to minimize confusion.
• When the jquery_app_folders library is not present, your theme preprocessor exits but views-app-folders.tpl.php still renders, resulting in a repeating error message:

  "Notice: Undefined variable: dom_id in include() (line 26 of C:\xampp\htdocs\demo\sites\default\modules\views_app_folders\theme\views-app-folders.tpl.php)."

None of this should stand in the way of releasing this as a module, but fixing these issues could definitely improve usability.

I have installed the module, and got it work flawlessly with a variety of data. Moreover, the code itself follows best practices and uses the APIs and hooks correctly, from what I can tell.

I am setting to RTBC, although I have one minor suggestion for improvement:

In the README.txt, where of

3. Place jQuery App Folders JS libraries into
sites/all/libraries/jquery_app_folders

I believe it is common practice to add something like:

so that the .js file is accessible at sites/*/libraries/jquery_app_folders/jquery.app-folders.js

In my case, I got the error on screen (in the preview of my View) because the library was not present; I then added the library and the error still occurred in the preview. The error then disappeared when I saved the view, but knowing exactly where the js file should be would have reassured me that I was using the library correctly. Likewise, the onscreen error says something like "Please install the jquery_app_folders library.". I would add to that "...as explained in the README.txt file".

Cheers,

Albert.

Picking this up as part of project review sprint

* Install instructions and requirements on the project page are good.
* HOWTO install is good
* Though I still don't know exactly what I'm installing yet...
* made my content type, with an image file attached. Made my view and selected this display. etc.

And, I get a list of thumbnails, no problems...
And, viewing the page .. OOh, nice :-)
I like it. Not sure how this actually matches with the screenshot on the project page, but there are possibilities.

I think there are a few image galleries that behave similar, but I can see the potential here.
-----------
* README good.
* Documentation comments fine.
* API usage (libraries and hooks) great.
* Javascript and css : looks sane
* Plugin code: clean and nicely minimal. Good to see error-checking.
* I'd SUGGEST using hook_requirements to ensure the js library is available, but really, what you've got is pretty good
* From a basic visual review, I like the theme func. Really good and clean, and compatible with expected conventions.

Yup, this is good!

Thanks for your contribution, quintux !

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

I mean [fixed] :-)