Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Log lines like these get a green color class...
Loading drushrc "/var/aegir/platforms/myplatform/sites/s3.example.com/drushrc.php" into "site" scope.
Bootstrap to phase 0.
Adding 'info' and 'message' to the info class would help this. This should match _drush_print_log()
patch comming...
Comment | File | Size | Author |
---|---|---|---|
#6 | hosting-clean_up_log-2037045-6.patch | 1.03 KB | ergonlogic |
#1 | hosting.miscellaneous.2037045-1.patch | 895 bytes | helmo |
Comments
Comment #1
helmo CreditAttribution: helmo commentedComment #2
ergonlogicThis has made the entire log grey for me.
Comment #3
ergonlogicfyi, these are all the task types I see:
Comment #4
ergonlogicOddly, all the rows are getting a class of 'hosting-info', but I don't see why...
Comment #5
ergonlogicSorry, almost everything was set to 'hosting-info'. I think 'message' should remain a 'hosting-success', no?
Comment #6
ergonlogicRevised patch for #5 attached.
If we go with what's in _drush_print_log(), then we should probably change all instances of
drush_log(..., 'message')
todrush_log(..., 'success')
, or something.Comment #7
ergonlogicFixed in Provision with d5a8862, and Hosting with 72f7db1.
As per #5, I switched to using 'success' rather than 'message' in Provision. This change means that 'status-info' is the default, so, for example, memory rows are no longer green. However, this better highlights the operations that are actually successful, and reduces the noise.
I think we could still tweak these a bit. For example, I think 'rollback' messages could be flagged as hosting-warning, and maybe 'debug' too.
Comment #8
helmo CreditAttribution: helmo commentedI think you forgot to push to provision... I can't find d5a8862 there.
Drush also uses the cancel type... in 8.x-6.x ... so that's not really aegir specific anymore.
includes/drush.inc: drush_log($msg ? $msg : dt('Aborting.'), 'cancel');
Comment #9
helmo CreditAttribution: helmo commentedThe hosting-dispatch cron-job now started mailing:
Updated task status to "Successful" [success]
Changing it to 'info' seems better:
Comment #10
ergonlogicOops, I'd missed a push from Provision. I also cleaned up the rest, as per your suggestions.
Comment #11
anarcat CreditAttribution: anarcat commentedGreat!
I think having rollbacks as warnings is a great idea, although they will probably always end up in red because a rollback usually happens after an error, which should be red. Debug should be inconspicuous.
Comment #12
anarcat CreditAttribution: anarcat commentedoups, didn't mean to change status.
Comment #13
ergonlogicok, I made rollbacks orange, even though the overall task will remain red.
Fixed in 7e31ccc