Project Description:

When working on different environments, such as development and production, absolute links are often accidentally entered in a page's content. This can happen through either copying and pasting an internal URL or simply typing it in, and it poses a problem when the website is moved to a different environment - especially production.

Having an absolute link pointing to a development environment when a website is live is certainly an unwanted situation, and that's what this module aims to prevent by:

  1. Letting the user select which content types he/she would like to search for absolute links
  2. Presenting a list of pages that contain absolute linking in their content
  3. And giving the user the option of automatically fixing the links - task which is usually tiring if performed manually

Project URL:

Fix Absolute Links Module

Git Repository URL

http://git.drupal.org/sandbox/hvasconcelos/2037323.git

CommentFileSizeAuthor
List of nodes which links were fixed.15.54 KBhvasconcelos
A list of nodes in which absolute links were found.30.78 KBhvasconcelos
A list of content types to check for absolute links.19.79 KBhvasconcelos
admin/structure page with link to the module.52.48 KBhvasconcelos

Comments

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxhvasconcelos2037323git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

hvasconcelos’s picture

hvasconcelos commented

I've gone through the automated review tool above and removed all of the warnings in the files.

hvasconcelos’s picture

hvasconcelos commented
Status: Needs work » Needs review
gabesullice’s picture

gabesullice
Primary language English
commented
Status: Needs review » Needs work

Hi hvasconcelos,

I'm looking forward to this module, it'll be pretty handy.

Review:
You're still on a master branch of the project. I'd suggest making a 7.x-1.x branch. Drupal.org has naming conventions for branches and releases (although not required at this early stage). Here's how to get off the master branch.

You still have quite a few errors and warnings on pareview.

Drupal coding standards disallow inline control structures. Pareview pointed out two of those on lines 101 and 132.

For example:

if (!isset($form_state['continue']))
  $form_state['continue'] = 0;
$form_state['continue']++;

should be

if (!isset($form_state['continue'])) {
  $form_state['continue'] = 0;
  $form_state['continue']++;
};
hvasconcelos’s picture

hvasconcelos commented
Status: Needs work » Needs review

Hey Gabriel,

Thank you so much for your feedback! I appreciate you including links with it too. I've followed the instructions you mentioned to switch to the 7.x-1.x branch in the repo and fixed the errors on pareview.

larseliasnielsen’s picture

larseliasnielsen commented

Hi,

Looks really nice, and goes through pareview without any errors or warnings.
I just looked through it manually and I can't put my finger on anything.

Great work.

hvasconcelos’s picture

hvasconcelos commented

Thanks for reviewing it, Lars :)

cbudzi’s picture

cbudzi commented
Status: Needs review » Needs work

Hello hvasconcelos!

At first I checked out the Masterbranch. Looks like you still have to set a new default branch on your project page.

Now for branch 7.x-1.x:

I checked fix_absolute_links.module line-by-line and found something:

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.