-      'left-top'      => t('Top') . ' ' . t('Left'),
-      'center-top'    => t('Top') . ' ' . t('Center'),
-      'right-top'     => t('Top') . ' ' . t('Right'),
-      'left-center'   => t('Center') . ' ' . t('Left'),

Not every language could combine 2 word in this way :)

eg:

In Eng, you would say:
Top Left

In other language it is:
Left Top

CommentFileSizeAuthor
#9 2037847-join-string-d7.patch1.21 KBdroplet
#4 2037847-join-string.patch1.4 KBdroplet
fix_string.patch1.23 KBdroplet

Comments

droplet’s picture

droplet commented
Issue summary: View changes

Updated issue summary.

droplet’s picture

droplet commented
Issue summary: View changes

Updated issue summary.

amourow’s picture

amourow
he/him/his
commented

Agreed, it's better described in a string for each spot in this case and good for translation.

amourow’s picture

amourow
he/him/his
commented
Issue summary: View changes

Updated issue summary.

droplet’s picture

droplet commented

fix_string.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, fix_string.patch, failed testing.

droplet’s picture

droplet commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new 2037847-join-string.patch1.4 KB

same patch, reroll only

droplet’s picture

droplet commented
Issue tags: +Novice, +Quick fix
droplet’s picture

droplet commented

4: 2037847-join-string.patch queued for re-testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Reviewed and looks a nice fix. I run grep for checking that there are not more occurrences of this after this patch, and does not look like.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Wow. That is utterly bizarre.

Git blame led me to #371374: Add ImageCache UI Core so this was part of the initial patch. No idea how I missed it back in 2009. :) I chalk it up to excitement about having an image cache UI in core. :D

Committed and pushed to 8.x. Thanks!

This can likely be backported to 7.x as well.

droplet’s picture

droplet commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 2037847-join-string-d7.patch1.21 KB
dawehner’s picture

dawehner
Primary language German
commented

Just wonder whether we should also remove the unnecessary whitespaces automatically.

izus’s picture

izus commented
Status: Needs review » Reviewed & tested by the community

i tested path #9,
it applied well and the result looks good for me.
Thanks

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: 2037847-join-string-d7.patch, failed testing.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review

9: 2037847-join-string-d7.patch queued for re-testing.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Above fail was an auto retest of an RTBC patch, failure was a bot fluke (probably disk space)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: 2037847-join-string-d7.patch, failed testing.

droplet’s picture

droplet commented
Status: Needs work » Needs review

9: 2037847-join-string-d7.patch queued for re-testing.

droplet’s picture

droplet commented
Status: Needs review » Reviewed & tested by the community

Test bots issues only, back to RTBC

  • Commit d161af6 on 7.x by David_Rothstein: 
    Issue #2037847 by droplet: Join position strings together to fix...
David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +7.27 release notes

Committed to 7.x - thanks!

David_Rothstein’s picture

David_Rothstein commented
Issue tags: -7.27 release notes +7.28 release notes

Drupal 7.27 was a security release, so this is now scheduled to go out in Drupal 7.28 instead.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.