There's some deprecated code and a simple @todo in pause.hosting.inc.

CommentFileSizeAuthor
#1 hosting-clean_up_pause-2037965-1.patch876 bytesergonlogic

Comments

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Status: Active » Needs review
StatusFileSize
new hosting-clean_up_pause-2037965-1.patch876 bytes

Patch attached.

anarcat’s picture

anarcat commented
Status: Needs review » Needs work

Great! Maybe we should put a status out while we wait?

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Status: Needs work » Fixed

Fixed in 2a7e0bb.

anarcat’s picture

anarcat commented
Status: Fixed » Needs work

fatal: ambiguous argument '2a7e0bb': unknown revision or path not in the working tree.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Status: Needs work » Needs review

Oops, I'd needed a rebase. Try aa054b2e

anarcat’s picture

anarcat commented
Status: Needs review » Needs work

missing t() and an explicit level - should this be info or message?

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Status: Needs work » Fixed

Sigh. ecc0985

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit aa054b2 on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by ergonlogic: 
    Issue #2037965: Clean up hosting-pause.

  • Commit aa054b2 on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by ergonlogic: 
    Issue #2037965: Clean up hosting-pause.