Verify "valid email address" during the hostmaster-install script?

We already do validate the admin email ininstall.hostmaster.inc. It'll bypass the check if the '-y' flag is set though. How are you running the install?

The site form is already overly complicated, so it'd be best not to add additional validation for such a corner case. Another approach might be to validate the email address in install_main() and so forth. We could then set a valid default and throw a warning.

Fixed in 77cbe7d.

I'm not sure I like the new default. 'localhost' is a valid domain, while 'example.com' is actually not: rfc2606 reserved that domain for "documentation and testing" purposes. While the idea behind the RFC is cover the situations where the "example.com" domain may "escape" test beds and documentation, it is fairly clear that it is not expected behavior.

We should instead use a real domain, preferably the domain associated with the server the site is on.

How's this for a start? First, we can't use expressions to define constants. For now, I just used global $url, since, at least we know it's a valid fqdn.

For "the domain associated with the server the site is on", I guess we can look up the task context, and then parse the 'master_url'. I think that'd be preferable to looking at $_SERVER['SERVER_NAME'] or the like. Since the site would be built on the master then synced out to remotes, this would end up using the master's domain (I think).

looks much better, thanks!

I considered doing this:

$server_url = parse_url(d()->server->master_url);
$email_domain = $server_url['host'];

While it works well, in that is uses "the domain associated with the server the site is on", it won't actually fix this issue. In fact, it gets us right back to square one.

Also, it turns out that 'global $url', is not in fact validated as an FQDN, so that doesn't help too much either. Since the point is to ensure the site install succeeds while throwing a warning that will prompt action, I went with the following:

function install_validate_client_email($client_email) {
  if (!$client_email || !filter_var($client_email, FILTER_VALIDATE_EMAIL)) {
    $invalid_email = 'this.email@is.invalid';
    drush_log(t('Error validating client email `!email`. Please check your !user email. To allow the site installation to proceed, the email `!invalid` has been used instead. Please use the `login` link to change the site admin email to a proper valid address.',
      array(
        '!email' => $client_email,
        '!user' => l(t('user account'), 'user'),
        '!invalid' => $invalid_email,
      )),
      'warning'
    );
    return $invalid_email;
  }
  else {
    return $client_email;
  }
}

I replaced example.com with '.invalid', since this appears to be a proper use of said TLD. Also, since it's independent of the version of Drupal being installed, I moved this function into install.inc.

Fixed in 16ce3af.

great! i didn't know about .invalid!