When we removed the duplicate links for local actions, this changed the route for views administration. However, the Views UI tour was not updated.

Attached resolves the issue.

CommentFileSizeAuthor
#7 views-ui-tour-2040369-7.patch1.88 KBxjm
#7 interdiff-tour.txt916 bytesxjm
views-ui-tour.patch1.87 KBxjm
views-ui-tour-FAIL.patch1.41 KBxjm

Comments

xjm’s picture

xjm
she/her
Primary language English
commented

Closed #2027469: View UI Tour is not working and had a sandbox update. as a duplicate of this issue.

Status: Needs review » Needs work
Issue tags: -VDC, -Tour

The last submitted patch, views-ui-tour.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
Issue tags: +VDC, +Tour

views-ui-tour.patch queued for re-testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Testing for this being worked on in #2028535: Provide a TourTestBase class for use by core and contrib modules

xjm’s picture

xjm
she/her
Primary language English
commented

@larowlan: For views, for now, it's probably better to implement Views' base test class (as I have) since this provides a test view pretty easily. This fixes a regression and tests are a gate.

We can add more thorough tests later based on the new base class. I'll comment on the other issue.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work

Great a patch!

+++ b/core/modules/views_ui/lib/Drupal/views_ui/Tests/ViewsUITourTest.phpundefined
@@ -0,0 +1,54 @@
+ * Contains \Drupal\tour\Tests\ViewsUITourTest.
...
+namespace Drupal\views_ui\Tests;

These two lines seems to disagree, but I agree it should be part of views_ui (that is the place of the config file).

+++ b/core/modules/views_ui/lib/Drupal/views_ui/Tests/ViewsUITourTest.phpundefined
@@ -0,0 +1,54 @@
+  }
+}

Needs an empty line.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-tour.txt916 bytes
new views-ui-tour-2040369-7.patch1.88 KB

Thanks @dawehner! Fixed in attached.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Thank you.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed f92f05c and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.