D7: restore search page integration, or remove dead code [#2044475]

features/drupalorg/search_advanced_issues.feature

Any search which narrows on the Advanced search facet is returning the text "Found results containing the words:" but no actual results when their should be. Instead the "Browse" listing is displayed.

For example, when I search for the word "test", which should have results:

http://git7site.devdrupal.org/search/issues?test=test

This may be a redirect issue since after performing the advanced search, I land on http://git7site.devdrupal.org/search/site.

Comments

Comment #1

eliza411 commented 17 July 2013 at 23:01

Issue tags:

+qa, +drupal.org D7

Tagging

Comment #1.0

eliza411 commented 17 July 2013 at 23:01

Project:	Drupal.org BDD	» Project issue tracking
Issue summary:	View changes

Adding description of redirect

Comment #2

drumm

he/him

NY, US

commented 10 September 2013 at 23:23

Version:	7.x-1.x-dev	» 7.x-2.x-dev
Component:	Broken site	» User interface

D7's new hook_search_info() should be implemented so project_issue_search_page() is active.

If this doesn't solve it, such as needing hook_search_execute() to be implemented too, we should consider using the /project/issues path and not bothering with the view pretending to be a type of search as core defines it.

Comment #3

drumm

he/him

NY, US

commented 18 October 2013 at 19:08

Assigned:

Unassigned

» drumm

Comment #4

drumm

he/him

NY, US

commented 18 October 2013 at 22:57

Title:	Advanced issue search returns no results	» D7: restore search page integration, or remove dead code
Assigned:	drumm	» Unassigned
Issue tags:	-qa, -drupal.org D7

I actually opted to bypass the search/issues path and go with the canonical project/issues/search in drupalorg, http://drupalcode.org/project/drupalorg.git/commit/2a054c8.

Leaving open because this still should be sorted out in project_issue. project_issue_search_page() is actually dead code at the moment, it doesn't have a menu callback. I think this may be intentional and we should remove that function. (Or maybe the D7 search-page-related hooks should be implemented to make search/issues active again.)