Page: Theming information (last item in collapsed Advanced section) is missing a label for the change theme form in the modal.

Missing Label

CommentFileSizeAuthor
#3 drupal8-missingViewsLabel-2044523-3.patch685 bytesbowersox
#3 Screen Shot 2013-07-21 at 3.17.15 PM.png222.59 KBbowersox
Screen Shot 2013-07-17 at 8.34.45 PM.png153.31 KBmgifford
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue tags: +Novice, +VDC

.

bowersox’s picture

bowersox CreditAttribution: bowersox commented
Issue tags: +TwinCities
bowersox’s picture

bowersox CreditAttribution: bowersox commented
FileSize
Screen Shot 2013-07-21 at 3.17.15 PM.png222.59 KB
drupal8-missingViewsLabel-2044523-3.patch685 bytes

Please review.

This is a 1-line patch to add a missing #title. Visually this adds a label. Screenshot attached.

bowersox’s picture

bowersox CreditAttribution: bowersox commented
Status: Active » Needs review
mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-4
CreditAttribution: mparker17 commented
Status: Needs review » Reviewed & tested by the community

Code looks good and works as desired! :)

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Reviewed & tested by the community » Closed (duplicate)

We don't actually want to add the title visually. See #933004: Test that all form elements have a title for accessibility. Sorry for the duplicate effort.