This modules contains submodules for interacting with The City software (http://developer.onthecity.org/)

Currently it includes the following submodules:

  • A module that allows users to login directly to The City from a Drupal website. Currently this module contains a submodule which provides a block with a form loaded from Javascript.

When the City's OAUTH API is released this module will contain other submodules which will act as a wrapper to the City's API.

https://drupal.org/sandbox/andyhails/2045185

git clone --branch master andyhails@git.drupal.org:sandbox/andyhails/2045185.git thecity

Comments

funex’s picture

funex commented
Issue summary: View changes

Updated issue summary.

PA robot’s picture

PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

arjkap’s picture

arjkap commented
Status: Needs review » Needs work

Hi,

Manual review of the 7.x-1.x branch :

1. Please correct the link to the project sandbox page. It gave me a 404 error.

2. You need to shift to a version specific branch in your git repo. There are some minor errors - http://ventral.org/pareview/httpgitdrupalorgsandboxandyhails2045185git

3. Please add a readme.txt file to your project.
4. I could not find any module or related files in your git repo. Please commit and push all the required files and then open the project for a review again.

arjkap’s picture

arjkap commented
Issue summary: View changes

Updated issue summary.

funex’s picture

funex commented
Issue summary: View changes

Updated the broken project URL to the sandbox URL.

funex’s picture

funex commented
Status: Needs work » Needs review

Hi arjkap,

Thanks for reviewing the module. I Apologise for the amount of errors - its my first module!

I've made those updates. It turns out there weren't any files there because I was using git submodules which just confused matters!
I've removed this so it should work as usual.

I've set the Status back to 'Needs Review'.

Many thanks,

Andy

andrewsizz’s picture

andrewsizz commented
Status: Needs review » Needs work

I have found strange structure of you files in git repo http://drupalcode.org/sandbox/andyhails/2045185.git/tree. It seems you need to delete all old files and you need to transfer all files from thecity_login directory into root.

funex’s picture

funex commented

Hi AndrewsizZ,

Thanks, the main module is a container other other modules that I intend to add. Currently the only submodule in there is thecity_login but there will be more. Do I still need to move the contents into the root directory?

Andy

funex’s picture

funex commented

Hi AndrewsizZ,

Thanks, the main module is a container other other modules that I intend to add. Currently the only submodule in there is thecity_login but there will be more. Do I still need to move the contents into the root directory?

Andy

andrewsizz’s picture

andrewsizz commented

Hi, but without .module file of main module it not looks correctly.

funex’s picture

funex commented

OK I will add a .module file :-)

funex’s picture

funex commented
Status: Needs work » Needs review

OK, I've reworked the file structure so that thecity_login module is in the root. As and when I create other modules to go in here I'll move this into it's own subdirectory.

Also, I've made other updates including:

  • Clearing up variables when uninstalling
  • Tweaks to the city library - it displayed an alert box when the subdomain wasn't present, it didnt feel very Drupal.
  • Cleaned up some white space at the end of a file.

Thanks

bhobbs-chitika’s picture

bhobbs-chitika commented
Status: Needs review » Needs work

Check http://ventral.org/pareview/httpgitdrupalorgsandboxandyhails2045185git to fix all issues.

Your variable need to include your project name. If your project name is The City Login, then all of your variable need to be thecity_login_{some_name} but most seem to be thecity_{some_name}. Refer to https://drupal.org/coding-standards#naming

I didn't find anything else that stuck out to me. Just fix all the reported issues by ventral.
Great job so far.

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

PA robot commented
Issue summary: View changes

Updated issue summary.