features/git/git_access_check.feature:26

I verified this manually as well. When git vetted user creates a sandbox, then unchecks the Git access agreement, they can still push to the repo.

Comments

halstead’s picture

halstead commented

The varnish cache isn't being cleared when users are updated. Changing your ssh key also will not take effect immediately. Clearing varnish manually after updating the user causes code/privileges to work as expected.

We used to intelligently clear a user's varnish entries whenever account details were changed. This doesn't appear to happen at the moment on git7site.

halstead’s picture

halstead commented

The code in drupalorg_git_varnish/drupalorg_git_varnish.module at drupalorg_git_varnish_user() should clear the user's data from the varnish cache but doesn't seem to do it at the moment.

marvil07’s picture

marvil07 commented

The problem was we were implementing an non-existing hook in D7, hook_user is not valid in D7.

I just changed that to use hook_user_update(). Please let me know if it works as expected.

eliza411’s picture

eliza411 commented

Thanks for looking at this. Drumm pulled this commit in last night, and the automated test is still failing. I've verified manually that a user is still able to push.

drumm’s picture

drumm
he/him
Location NY, US
commented
Assigned: Unassigned » drumm
drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Active » Fixed

I changed drupalorg_git_varnish_http.host from localhost:8888 to git7site.devdrupal.org:8888 in settings.local.php.

Automatically closed -- issue fixed for 2 weeks with no activity.