Closed (fixed)
Project:
Hostmaster (Aegir)
Version:
6.x-2.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
19 Jul 2013 at 20:11 UTC
Updated:
27 Mar 2020 at 14:06 UTC
Jump to comment: Most recent
Subdirectory support (#705026: Allow creation of example.com/foo and example.com/bar type of sites (Part I)) is still very preliminary and needs those issues to be fixed before completion:
Nginx support missing (issue #2020091)- done!If- fixed!example.com/foois created, theexample.comvirtual will be overwritten and the site inaccessible under that domain (issue #2020089)Multi-server support is untested (issue #2020079)- tested, fixed and merged in 2.x!Code needs to be refactored to the new 2.x API (issue #2020075)- done!- #2098389: subdirs kicks in even when subdirs module is disabled.
- #2099883: Validate an alias has parts (subdirs)
- #2100181: Symlink missing for D6 subdir sites
- usability: the site form could be improved, ideally we would just type foo.example.com/bar in the site title or alias field and everything would "just work". See: #2186923: Allow example.com/foo activate subdirs on a site for follow-up.
Comments
Comment #1
cweagansWould anyone be willing to work on this for money? If so, can you please estimate the amount of time required and send me your hourly rate? Please note that I don't much care about nginx support.
At this point, it doesn't look like subdirectory support works at all.
Comment #2
anarcat commentedcan you elaborate on what is not working?
financing this would indeed help in prioritising this work. i can provide an estimate once i figure out exactly what's broken, somewhere next week.
Comment #3
anarcat commentedSo it turns out that I just can't figure out how to make a subdir site in Drupal, regardless of aegir. See #2097689: clean_urls don't work well with subdirectory.
Comment #4
anarcat commentedphew, figured that one out, now back into looking at multi-server support.
Comment #4.0
helmo commentedUpdated issue summary.
Comment #4.1
helmo commentednew spunn-off task
Comment #4.2
anarcat commentedupdate
Comment #5
anarcat commentedOkay, this is looking pretty good now - the code has been refactored, multi-server works, as far as I know, and code was really cleaned up.
We still don't support example.com + example.com/foo, and nginx support is still missing. I have removed the link to this issue: #2020087: Use the <Location>-based approach from subdirs for all site vhosts - as it is relevant only to fix the example.com problem.
All code now sits on the main 2.x branch, and would need further testing.
Comment #6
cweagansI will test this in the next two weeks or so. Thanks for the hard work on this!
Comment #7
anarcat commentednote that i have a potential fix for example.com support in #2020089: Allow example.com and example.com/foo domains, feedback and testing welcome.
Comment #7.0
anarcat commentedremove the thing, we'll do it only as part of the example.com fix
Comment #7.1
anarcat commentedadd a new issue
Comment #8
omega8cc commentedComment #9
omega8cc commentedComment #10
omega8cc commentedMultiple (tested) fixes committed.
Happy New Year!
Comment #11
anarcat commentedWow, that's great, thanks for the good work!
Now it seems the only issue remaining is usability, I added this to the list:
the site form could be improved, ideally we would just type foo.example.com/bar in the site title or alias field and everything would "just work"
Comment #12
ergonlogicAll the sub-issues are closed except a note for UI improvements. I added #2186923: Allow example.com/foo activate subdirs on a site to follow-up on that.
Comment #14
colanAdded meta issue part number.