Mark invalid form field with [aria-invalid=true]

I don't think this is quite right, but wouldn't it be great if it just worked!

This will probably need tests too.

Adding form api tag

Hello all,
Please find attached two patch files. The first is a test only and should fail, and the second file contain the fix.
Though my manual test using a screen reader and checking page source, the aria-invalid attribute is there once a testfield isn't filled.

+++ b/core/includes/form.incundefined
@@ -4842,6 +4842,7 @@ function _form_set_attributes(&$element, $class = array()) {
+	$element['#attributes']['aria-invalid'] = TRUE;

So the fix is also in the .fail file. Ideally the .fail file should only contain the tests changes and should fail testing - demonstrating that the new tests catch the missing functionality, then the 'fix + tests' patch is the .pass file - this shows that the fix works. Hope that makes sense. But not a big deal.

+++ b/core/includes/form.incundefined
@@ -4842,6 +4842,7 @@ function _form_set_attributes(&$element, $class = array()) {
+	$element['#attributes']['aria-invalid'] = TRUE;

+++ b/core/modules/system/lib/Drupal/system/Tests/Form/FormTest.phpundefined
@@ -248,6 +248,9 @@ function testRequiredTextfieldNoTitle() {
+	$this->assertFieldByXPath('//input[contains(@aria-invalid, TRUE)]', FALSE, 'Aria invalid attribute found.');

Both lines use tabs for adding the indent, the Drupal standard is to use spaces. See http://drupal.org/coding-standards. You can update your editor to use spaces and never think of it again. You can also configure git to warn you - see http://drupal.org/node/1542048 for the recommended git config.

Attached are the corrected patches. Including fixes to the code that didn't comply with Drupal coding standards.

Again, like before, the first file is the test only and the second file is the fix.
(Hope I sorted it properly!)

Close, the fail one is fine (and no need to re-upload as it will show that the tests catch what we're trying to catch).
But the pass one should be the 'complete' patch as in the patch that will be applied - so it should contain the tests (like the fail one) and the fix.
So the file size should be around the 1.2 kb (400b + 800b).
Whitespace looks good.
So if we can get a complete patch that includes the fix and the test - we're nearly done in my opinion.
Thanks again.

For some reason when i created the pass patch (just tried it again) it seemed to exclude the test. Here's the results of the new pass patch.

diff --git a/core/includes/form.inc b/core/includes/form.inc
index a789322..2b1743a 100644
--- a/core/includes/form.inc
+++ b/core/includes/form.inc
@@ -4842,6 +4842,7 @@ function _form_set_attributes(&$element, $class = array())
   }
   if (isset($element['#parents']) && form_get_error($element) !== NULL && !empt
     $element['#attributes']['class'][] = 'error';
+    $element['#attributes']['aria-invalid'] = TRUE;
   }
 }
 
diff --git a/core/modules/system/lib/Drupal/system/Tests/Form/FormTest.php b/cor
index f402395..e136ef3 100644
--- a/core/modules/system/lib/Drupal/system/Tests/Form/FormTest.php
+++ b/core/modules/system/lib/Drupal/system/Tests/Form/FormTest.php
@@ -248,6 +248,9 @@ function testRequiredTextfieldNoTitle() {
     // Check the page for the error class on the textfield.
     $this->assertFieldByXPath('//input[contains(@class, "error")]', FALSE, 'Err
 
+    // Check the page for the aria-invalid attribute on the textfield.
+    $this->assertFieldByXPath('//input[contains(@aria-invalid, TRUE)]', FALSE, 
+
     // Submit again with required fields set and verify that there are no
     // error messages.
     $edit = array(
(END)

We still need a pass/fail to show the tests do what they're supposed to, the patches above all passed, which means the tests (in the earlier patches) are a false positive. I suspect the explicit 'true' string will rectify this, but uploading in two parts to verify and demonstrate to reviewers/committers that the latest patch tests work as expected™.
If we see red/green for these two, its rtbc in my opinion.

I asked an admin to cancel the test run on #9 as #11's pass patch is the same thing. No need to overload the bot.

This is RTBC in my book but given I worked on the original patch with @Caecus in office hours and uploaded the last version I'll leave that to someone else.

Here we go.

Awesome! Thanks, Caecus and larowlan!

Nice!

Committed and pushed to 8.x. Thanks!

Does this happen to help with #742344: Allow forms to set custom validation error messages on required fields or #1493324: Inline form errors for accessibility and UX or #1797438: HTML5 validation is preventing form submit and not fully accessible by any chance?

I don't think it's going to help with those other issues.

Glad this patch is committed & also nice that it was discovered in a #a11y sprint!