Support for Per-Bundle Settings on Name Module

I think that this did once, but that was literally years ago from memory. A quick scan of the first commit post GIT migration only has the field settings (26 Feb 2011).

Happy to consider patches for instance overrides. Note that an additional preprocessor / field alter could be added to name element to alter it's behaviour based on the associated entity IFF this change is globally consistent across the crm. However I expect that this is not the case.

If you consider a patch, I think that this should be fairly limited and just cover the components / min components in the instance settings. I would make this state controlled, nested under a checkbox to toggle the visibility. [ ] Override field settings (or something along these lines)

BTW, CSS settings are being dropped in favor of external CSS / templates in 8.x port, and the autocomplete (names db integration) is being dropped completely in 8.x simplifying things considerably.

Hi Alan,
Thanks for the advice!
We're making some progress on a patch, allowing for configuring some settings to be per instance.
Rosk0 will be in touch when it's ready. Cheers!

Initial patch version.

Nice start. I don't think that I'd include any special logic for the # field instances, KISS reduces the complication internally

I had a quick look at the code last night, simply inserting the label options directly into the other instance settings was fairly tidy, leaving just the component bits as something additional

# name_field_info()
        // Allows a given or family component value to filful either both the
        // minimal components. Allows singular names like "Prince".
        'allow_family_or_given' => 0,
+      'labels' => array('title' => '','given' => '', 'middle' => '', 'family' => '', 'generational' => '',
 'credentials' => ''),

# _name_field_instance_settings_form()
    $form['inline_css'][$key] = array(
      '#type' => 'textfield',
      '#title' => t('Additional inline styles for !title input element.', array('!title' => $title)),
      '#default_value' => isset($settings['inline_css']) ? $settings['inline_css'][$key] : '',
      '#size' => 8,
    );
+    $form['labels'][$key] = array(
+      '#type' => 'textfield',
+      '#title' => t('Label for !title', array('!title' => $title)),
+      '#default_value' => $settings['labels'][$key],
+      '#size' => 12,
+    );
  }

# _name_field_instance_settings_pre_render($form)
        . '<li>' . t('Additional inline styles for the input element. For example, "width: 45px; background-color: #f3f3f3"') . '</li>'
+        . '<li>' . t('Optional overrides for field labels.') . '</li>'
....
    unset($form['instance_inline_css'][$key]['#description']);
    unset($form['instance_inline_css'][$key]['#title']);

+    unset($form['instance_labels'][$key]['#description']);
+    unset($form['instance_labels'][$key]['#title']);
...
    $form['styled_settings']['tbody']['inline_css'][$key]['#weight'] = $i;

+    $form['styled_settings']['tbody']['labels'][$key] = $form['instance_labels'][$key];
+    $form['styled_settings']['tbody']['labels'][$key]['#prefix'] = '<td>';
+    $form['styled_settings']['tbody']['labels'][$key]['#suffix'] = '</td>';
+    $form['styled_settings']['tbody']['labels'][$key]['#weight'] = $i;

i.e.

@Alan D.: Thanks for guidance. New patch version includes proposed way of override components labels and some other fixes.

Number of issues found while looking at this, I will address in the next week or so.

The biggest was the UI, the instance settings should not be in the field settings IMHO. I am starting to refactor and this is the UI that I am considering. Overrides are in the main table and are always visible.

Then there are a few other things that need addressing, but I should have time soonish to finish off. ETA by the end of next weekend.

And the promised patch ;)

As far as I can tell, only devel_generate and some validation issues were missing from #7, and added here, but I must say that this patch has had very little testing.

Me bad, this one was tested on both an instance and a default (field) name field... Test failure still to check...

Empty test on the field components was throwing that message. If empty, the minimum component required message is suppressed as the fields are required and that message is shown. (i.e. change required to bypass validation of the instance settings which can be empty)

Patch works great.

Patch works great.

Wow, two reviews... two more than 98% of all patches in my queues ;)

Thanks guys, committed.

Will watch the usage rates and consider pushing a new tag in the next month or so.

I'll keep a clear distinction between the settings that could alter the data that is stored and those settings that only affect the display in D8.

Display settings to be moved to the form display mode settings.

With that in mind, these issues have no overlap and see #3001715: Name field form display settings