Freakynit feedback code formatting?

http://ventral.org/pareview/httpgitdrupalorgsandboxfreakynit2050011git

@see drupal coding standards

FILE: /var/www/drupal-7-pareview/pareview_temp/css/main.css
--------------------------------------------------------------------------------
FOUND 232 ERROR(S) AFFECTING 84 LINE(S)
--------------------------------------------------------------------------------
3 | ERROR | Multiple selectors should each be on a single line
4 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
4 | ERROR | Spaces must be used to indent lines; tabs are not allowed
4 | ERROR | Expected 1 space after colon in style definition; 0 found
5 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
5 | ERROR | Spaces must be used to indent lines; tabs are not allowed
5 | ERROR | Expected 1 space after colon in style definition; 0 found
8 | ERROR | Expected 1 space before opening brace of class definition; 0
| | found
9 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
9 | ERROR | Spaces must be used to indent lines; tabs are not allowed
9 | ERROR | Expected 1 space after colon in style definition; 0 found
10 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
10 | ERROR | Spaces must be used to indent lines; tabs are not allowed
10 | ERROR | Expected 1 space after colon in style definition; 0 found
14 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
14 | ERROR | Spaces must be used to indent lines; tabs are not allowed
14 | ERROR | Expected 1 space after colon in style definition; 0 found
18 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
18 | ERROR | Spaces must be used to indent lines; tabs are not allowed
18 | ERROR | Expected 1 space after colon in style definition; 0 found
19 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
19 | ERROR | Spaces must be used to indent lines; tabs are not allowed
19 | ERROR | Expected 1 space after colon in style definition; 0 found
20 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
20 | ERROR | Spaces must be used to indent lines; tabs are not allowed
20 | ERROR | Expected 1 space after colon in style definition; 0 found
21 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
21 | ERROR | Spaces must be used to indent lines; tabs are not allowed
21 | ERROR | CSS colours must be defined in lowercase; expected #aaa but
| | found #AAA
22 | ERROR | Line indented incorrectly; expected 2 spaces, found 1
22 | ERROR | Spaces must be used to indent lines; tabs are not allowed
25 | ERROR | Expected 1 space before opening brace of class definition; 0
| | found 
.......................

Hello, it seems that there are still hundreds of lines of errors @ http://ventral.org/pareview/httpgitdrupalorgsandboxfreakynit2050011git

Most of them seem to be with code formating. Check out Drupal standards on indentation.
Also make sure that anything read by the user is passed through t() function so that it may be translated if need be.

drupal_set_message(t('An error occurred and processing did not complete.'), 'error');

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

manual review

After install admin pages not load, users perms doesn't appears. Your filenames must start with freakynit (I suppose that this is the name of your module) not webengage (and functions the same).

README.txt

I think you should increase the information displayed in the file rather than send to external URLs (you can not access the network at the time of installation)

freakynit.module

In this file you mixed two names of module? The module calls freakynit but you write a lot of hook like "webengage". Examples:

  function webengage_perm() {
  function webengage_menu() {
  ....

the hooks implementations have to start with your module name:

 /**
  * Implements hook_perm().
  */
  function freakynit_perm() {
    return array('access webengage', 'create webengage', 'administer webengage');
  }

Don't use module_load_include to include file of your module, use require_once instead (module_load_include is to include files of another module). Example:

require_once realpath(__DIR__) . '/your file';

line 32

$items[PATH_MAIN]

Don't use a constant defined in another file (webengage_constants.php) to set the items in your hook_menu, it is confused. When you define constants try to use names with your module name. Constants like "PATH_MAIN, PATH_CALLBACK..." are a bit global and may be used in another modules.

You have two .info files (freakynit and freakynit_feedback).

It's seems that you have three name for your module: freakynit freakynit_feedback and webengage. You must unified it and apply the selected name to all module.

Take a look to code-standards https://drupal.org/coding-standards

Good luck!!

Hi,

Please review your code through ventral.org so that your code is compliant with drupal coding standards. You can do this manually.

- .install file line 53
there is no need to call cache_clear_all() in hook_install() as whenever a new module is installed, drupal clears cache itself.

- .module file line 24
your module seems to be in drupal core 7.x as i can see in .info file, please use hook_permission() instead of hook_perm() for providing permisisons. The way you provide permissions in 7.x is a little different. Please refer https://api.drupal.org/api/drupal/modules!system!system.api.php/function/hook_permission/7

- README.txt file
please give proper description of your module, especially what are the extra .php files used for

- CHANGELOG.txt
no need to provide this file in your initial module release

Hello.

I have to correct one of the points of my review. Sorry. In the review process of a module of mine told me that instead utilizase module_load_include required, so I adopted that point as a correction to make.

My module has passed the review process, but the person who enabled the publication of the project (cweagans) commented as follows on the subject:

For this bit:

 389 /**
 390  * include the block functions file
 391  */
 392 require_once realpath(__DIR__) . '/pay_with_a_tweet.blocks.inc';
 393 
 394 /**
 395  * include the tokens functions file
 396  */
 397 require_once realpath(__DIR__) . '/pay_with_a_tweet.tokens.inc';

1) To load module include files, you should use module_load_include; and
2) If you're including this unconditionally, there's no reason to split them out into another file. It is, in fact, a bit slower, since you're adding a couple of disk reads/file open operations into the mix. You could probably just copy the contents of those files into your .module file and you'd be fine.

I understand that, in this case, it is better to follow the recommendation of a person who can enable publishing projects.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.