This allows OG Administrators to add custom CSS to an organic group. Need to give admins ability to modify OG look and feel without creating a new theme (as is required by og_theme).

Project Page: https://drupal.org/sandbox/zipymonkey/2037975
Git Clone: git clone --branch 7.x-1.x git.drupal.org:sandbox/zipymonkey/2037975.git

Thanks

Comments

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxzipymonkey2037975git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

garnett2125’s picture

garnett2125 commented

Hi,

Manual review:

- og_css_injector.module Line 137 : The variable $rule is not used anywhere in the function.
- Maybe the README.txt could be a little more filled with information on how to setup your module.

=)

garnett2125’s picture

garnett2125 commented
zipymonkey’s picture

zipymonkey commented
Status: Needs work » Needs review

Thanks for the feedback @garnett2125. I've implemented the changes you've suggested and fixed errors reported by pareview.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Seems pretty short and sweet!

In og_css_injector_edit(), you can use form type 'value' instead of hidden. It's pretty much the same, but won't be printed to the form's html. The values will still be available when the form is submitted. That's a minor issue though.

Thanks for telling users that the permission is dangerous to assign. Generally letting users write files onto the server is not a good idea, but it seems like they could only do that to the public://og_css_injector/ directory, and only files with a .css extension, so that seems safe enough.

----
Top Shelf Modules - Crafted, Curated, Contributed.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Reviewed & tested by the community » Fixed

It's been a month without any problems reported, so I'm promoting this myself as per https://drupal.org/node/1125818.

Thanks for your contribution, zipymonkey!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.