Line 8 of utility/_dependencies.scss imports the variables partial (after importing a bunch of libraries such as susy etc). This doesn't seem to really do anything as _utility.scss (one directory higher) is also importing variables, after dependencies.

I doubled checked this by removing the import on line 8 of utility/_dependencies.scss and it seemed to have no effect.

CommentFileSizeAuthor
#1 remove_variables_import-2051679-1.patch368 bytesdddbbb

Comments

dddbbb’s picture

dddbbb commented
Status: Active » Needs review
StatusFileSize
new remove_variables_import-2051679-1.patch368 bytes

Patch attached.

fubhy’s picture

fubhy commented
Status: Needs review » Closed (works as designed)

Variables are required very early as they are (potentially) needed by external libraries (e.g. compass reads from the $legacy variables to adjust the output for which IE version you want to support). Hence, they have to be available everywhere (so, yes, "_utility.scss" is the right place) and they have to be imported early.

You have to understand the variable inheritance in Sass to fully understand why it works like this and makes total sense. Please read about variable inheritance and how the "!default" suffix works to fully understand this (you can find that in the sass documentation on the web).

dddbbb’s picture

dddbbb commented

Thanks for taking the time to reply but I'm not sure if a) I still don't quite understand your reasoning (entirely possible - hence not re-opening the issue) or b) perhaps you've misunderstood the point I was trying to make. I'll try to clarify in case of the latter.

Variables are required very early as they are (potentially) needed by external libraries (e.g. compass reads from the $legacy variables to adjust the output for which IE version you want to support). Hence, they have to be available everywhere (so, yes, "_utility.scss" is the right place) and they have to be imported early.

I totally get this and it's not what I'm disputing. My question is not, "why are variables loaded so early?", nor is it "why are variables loaded in _utility.scss?". My question is "why are variables imported *again* in _dependencies.scss when they've just been imported via _utility.scss, especially given the import order in _utility.scss (variables followed by dependencies - naturally)?" It seems to me that that second import of variables (in _dependecies.scss. *after* importing all the libraries) is doing nothing. Commenting out that import line & recompiling to CSS seems prove that theory: no errors, no visible/functional difference that I've managed to spot.

I have read up on the !default suffix in Sass as you suggested but it still doesn't seem to shed any light on the above point. The suffix is only used once in Ohm (abstractions/_grid.scss) to help with toggling susy-grid-background. I've tested around this and my patch doesn't seem to affect any of that.

If you're still confident that I'm wrong then please don't worry about replying - I'm sure you're very busy maintaining this splendid project; I'm sure I'll figure it out eventually and I don't want to be an unnecessary PITA :D

fubhy’s picture

fubhy commented
Status: Closed (works as designed) » Active

Oh, yes, I misunderstood you. Sorry... Just answered it quickly while on the train and didn't check the code nor read the question thoroughly. My bad. Yes, it's redundant to import it in _dependencies.scss again. Must be a copy&paste error.

fubhy’s picture

fubhy commented
Status: Active » Fixed

Commited to 4.x-dev. Also fixed it in the extended starterkit before commit. Congratulations on your first commit.

http://drupalcode.org/project/omega.git/commit/b18f26d

dddbbb’s picture

dddbbb commented

A credit!! Woop!

May it be the first of many :D

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.