Standardize on \Drupal throughout core

That is a good example of how things are at the moment!

Sounds good to me though. If we're going down the route of just one, that's our only choice.

I definitely think this is a good idea.

Imagine that you are new to object-oriented programming and you are wondering when to use "\Drupal" vs "Drupal." What do you do? Search the web for "Drupal \Drupal"? While that does produce some helpful results, it seems just as likely that someone might not know to search for that and would instead be wondering if they should use \Drupal::moduleHandle, \Drupal::entityManager, \Drupal::config, etc.

For whatever it's worth, I know for a fact that I have seen people ask this question in issue queues, and I have not been able to find many examples by searching. So not to pick on anybody, but here is one I remember: #1158322-152: Add backtrace to all errors

I'm not saying developers could not figure this out -- just that it might be complicated to know how to find the answer to the question. So if we can make one thing less confusing about Drupal 8, I'm all for it.

I wholeheartedly agree.

We either have

 Drupal::
(Drupal::
!Drupal::

or in authorize.php, Drupal:: at the beginning of the line.

So it was pretty easy to replace them all.

git diff --color-words showed that only \ was added.

It's trivial enough to reroll this patch, but often a "needs review" issue will get more attention than an "active" one, so why not.

The alternative of course is to use Drupal; in namespaced code where needed, and then drop the backslash everywhere.

The alternative of course is to use Drupal; in namespaced code where needed, and then drop the backslash everywhere.

Nope, that leads to silly things like

use \stdClass;
use \Exception;
use \PDO;
use \Drupal;
use \Iterator;
use \ArrayAccess;
use \Serializable;

Why is that silly? Why have one standard for top-level classes, and another standard for namespaced classes? You also don't need the leading backslash in use statements.

Also note core/lib/Drupal/Core/Config/Schema/ArrayElement.php which already has five use statements like this.

This patch comes in two parts because I was getting a request entity too large otherwise.

Sorry, botched up the regex, the correct one is (?<!\\)Drupal:: and the replacement (in phpstorm at least) \\\\Drupal:: Hope this works.

OMG core changed since I started rolling it :P

#15: 2053489_15.patch queued for re-testing.

#1199946: Disabled modules are broken beyond repair so the "disable" functionality needs to be removed reintroduced a couple dozen Drupal:: calls with no leading \.

Another one added in #2062023: Replace user_access() calls with $account->hasPermission() in statistics module

$ grep -rin '[^\\]Drupal::' *
core/modules/menu/menu.module:502:    '#access' => Drupal::currentUser()->hasPermission('administer menu'),
core/modules/statistics/statistics.module:61:    if (Drupal::currentUser()->hasPermission('view post access counter')) {

Added those two.

Verified that we are doing nothing else here but adding back slashes to Drupal::.

Gnah, wrong patch format in #22.

Committed 3742257 and pushed to 8.x. Thanks!

related follow up #2100329: Use \Drupal instead of Drupal to make IDEs and static code analyse tools happy