@Dries in #1978910-62: Convert layout_page_view to a Controller:

Given that we're pretty much at the end of the development cycle and layout module isn't actually used it core, it may be better to remove layout module from core? Thoughts?

@EclipseGc in #1978910-66: Convert layout_page_view to a Controller:

I agree this should absolutely be removed before 8.0 (or sooner) if we don't have code that is using it

#10 layout-remove-10.patch63.64 KBeffulgentsia
PASSED: [[SimpleTest]]: [MySQL] 58,476 pass(es).
[ View ]
#3 remove-layout.patch62.54 KBtstoeckler
PASSED: [[SimpleTest]]: [MySQL] 58,201 pass(es).
[ View ]


Status:Active» Postponed
Issue tags:+revisit before beta

Postponing and tagging "revisit before release" per request in #1978910-66: Convert layout_page_view to a Controller. Also, I tagged this "Approved API change", since per the issue summary, Dries suggested the removal to begin with.

Status:Postponed» Active

If we're going to do this, I'd rather do it asap rather than later. Removing a module is considerably harder than adding one. Once we get to beta we'll support beta-beta upgrade paths - so what happens if we remove the module on a site that has it enabled?

Status:Active» Needs review
new62.54 KB
PASSED: [[SimpleTest]]: [MySQL] 58,201 pass(es).
[ View ]

This is a simple git rm -r core/modules/layout. I grepped for "layout" in core and couldn't find anything related.

Priority:Normal» Major
Status:Needs review» Reviewed & tested by the community
Issue tags:+D8 upgrade path

Patch looks good. Raising priority and tagging as upgrade path related per #2.

Assigned:Unassigned» Dries

Dries agreed to postpone this to give SCOTCH folks more time, so it seems like he should be the one to commit the patch if he feels enough time has passed.

Just wondering, if this makes sense when we do start using it with the #2055853: [meta] Improve the place block UX; Separate interaction from the create block UX; Improve the existing blocks-by-theme layout. This needs some more management.

We're not using it. That issue is about "Improve the existing blocks-by-theme layout". Not "Improve the existing blocks-by-layout layout".

@Bojhan: Perhaps you meant #1787956: Make blocks relate to layout instances instead of themes, but that got pushed to D9 recently.

Status:Reviewed & tested by the community» Needs work

I just committed #1978910: Convert layout_page_view to a Controller, so this'll need a re-roll.

Status:Needs work» Needs review
new63.64 KB
PASSED: [[SimpleTest]]: [MySQL] 58,476 pass(es).
[ View ]

Same git command as in #3.

Status:Needs review» Reviewed & tested by the community

Probably fine to go straight back to RTBC on this. If 'bot disagrees, it'll kick it back.

Status:Reviewed & tested by the community» Fixed

Committed to 8.x. Thanks. Sad to see the module go but we can add it back in in Drupal 9.

What should we do with https://drupal.org/node/1813372 now, delete? edit? Post a new one?

Title:Remove layout.module from coreChange notice: Remove layout.module from core
Priority:Major» Critical
Status:Fixed» Active
Issue tags:+Needs change record

Has to be either delete + new one or edit the existing one for change notice, not sure which is best.

Assigned:Dries» Unassigned

I vote for delete + new so that it gets to https://twitter.com/drupal8changes, RSS, etc.

Do we have to reopen #1787846: Themes should declare their layouts and move it to D9?

I think so yes, I also support deleting the old CN and adding a new one that documents this change. No one should come across the old one while trying to upgrade their modules to D8. (we might want to consider some sort of "removed" tag for any other instance of CN's who's underlying code has been removed?)


Cool URIs don't change

I just blanked the date to put it back at the top of the list with "[REVERTED]" in the title, and gave a pointer to https://drupal.org/project/layout. Also moved all the active layout.module issues there and will delete the component in a sec.

I'll go commit the old code from D8 core to the contrib project there momentarily.

Status:Active» Fixed

Title:Change notice: Remove layout.module from coreRemove layout.module from core
Priority:Critical» Major
Issue tags:-revisit before beta, -Needs change record

Automatically closed -- issue fixed for 2 weeks with no activity.